Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
util: use `iter(callable, sentinel)` instead of while True
authorAugie Fackler <augie@google.com>
Fri, 05 Aug 2016 14:00:46 -0400
changeset 29730 4d23cd6e2219
parent 29729 44ea12756fef
child 29731 8d1cdee372e6
util: use `iter(callable, sentinel)` instead of while True This is functionally equivalent, but is a little more concise.
mercurial/util.py file | annotate | diff | comparison | revisions 
--- a/mercurial/util.py	Fri Aug 05 14:00:39 2016 -0400
+++ b/mercurial/util.py	Fri Aug 05 14:00:46 2016 -0400
@@ -1012,10 +1012,7 @@
             proc = subprocess.Popen(cmd, shell=True, close_fds=closefds,
                                     env=env, cwd=cwd, stdout=subprocess.PIPE,
                                     stderr=subprocess.STDOUT)
-            while True:
-                line = proc.stdout.readline()
-                if not line:
-                    break
+            for line in iter(proc.stdout.readline, ''):
                 out.write(line)
             proc.wait()
             rc = proc.returncode
mercurial