reuse-delta-base: improves some documentation
authorPierre-Yves David <pierre-yves.david@octobus.net>
Mon, 17 Oct 2022 16:26:16 +0200
changeset 49666 4bd12c0f531e
parent 49664 f56873a7284c
child 49667 191f5057ec45
reuse-delta-base: improves some documentation The current code got me a bit confused initially. So a bit more documentation around it cannot hurt.
mercurial/configitems.py
mercurial/scmutil.py
--- a/mercurial/configitems.py	Fri Nov 25 15:14:40 2022 +0100
+++ b/mercurial/configitems.py	Mon Oct 17 16:26:16 2022 +0200
@@ -2075,6 +2075,7 @@
     b'revlog.reuse-external-delta',
     default=True,
 )
+# This option is True unless `format.generaldelta` is set.
 coreconfigitem(
     b'storage',
     b'revlog.reuse-external-delta-parent',
--- a/mercurial/scmutil.py	Fri Nov 25 15:14:40 2022 +0100
+++ b/mercurial/scmutil.py	Mon Oct 17 16:26:16 2022 +0200
@@ -1858,7 +1858,12 @@
 
 
 def gddeltaconfig(ui):
-    """helper function to know if incoming delta should be optimised"""
+    """helper function to know if incoming deltas should be optimized
+
+    The `format.generaldelta` config is an old form of the config that also
+    implies that incoming delta-bases should be never be trusted. This function
+    exists for this purpose.
+    """
     # experimental config: format.generaldelta
     return ui.configbool(b'format', b'generaldelta')