--- a/contrib/check-code.py	Fri Jan 27 02:59:59 2012 +0100
+++ b/contrib/check-code.py	Fri Jan 27 03:00:03 2012 +0100
@@ -71,6 +71,7 @@
     (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
     (r'^stop\(\)', "don't use 'stop' as a shell function name"),
     (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
+    (r'^alias\b.*=', "don't use alias, use a function"),
   ],
   # warnings
   []

--- a/tests/test-phases-exchange.t	Fri Jan 27 02:59:59 2012 +0100
+++ b/tests/test-phases-exchange.t	Fri Jan 27 03:00:03 2012 +0100
@@ -2,7 +2,7 @@
   > [extensions]
   > graphlog=
   > EOF
-  $ alias hgph='hg log -G --template "{rev} {phase} {desc} - {node|short}\n"'
+  $ hgph() { hg log -G --template "{rev} {phase} {desc} - {node|short}\n" $*; }
 
   $ mkcommit() {
   >    echo "$1" > "$1"

--- a/tests/test-phases.t	Fri Jan 27 02:59:59 2012 +0100
+++ b/tests/test-phases.t	Fri Jan 27 03:00:03 2012 +0100
@@ -1,4 +1,4 @@
-  $ alias hglog='hg log --template "{rev} {phaseidx} {desc}\n"'
+  $ hglog() { hg log --template "{rev} {phaseidx} {desc}\n" $*; }
   $ mkcommit() {
   >    echo "$1" > "$1"
   >    hg add "$1"