Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:37:51 +0100
changeset 50620 26e63204c31e
parent 50619 2704dc40cf10
child 50621 822320591c46
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/templateutil.py file | annotate | diff | comparison | revisions 
--- a/mercurial/templateutil.py	Fri Feb 03 02:57:49 2023 +0100
+++ b/mercurial/templateutil.py	Thu Feb 02 17:37:51 2023 +0100
@@ -858,7 +858,7 @@
         )
     elif thing is None:
         pass
-    elif not util.safehasattr(thing, b'__iter__'):
+    elif not util.safehasattr(thing, '__iter__'):
         yield pycompat.bytestr(thing)
     else:
         for i in thing:
mercurial