Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
phases: fix error return with no exception from computephases()
authorYuya Nishihara <yuya@tcha.org>
Sat, 18 Jul 2020 18:13:41 +0900
changeset 45175 211063648b29
parent 45174 f93a4e3d35ab
child 45176 3264d58e8b06
phases: fix error return with no exception from computephases() PySet_Check() does not set an exception.
mercurial/cext/revlog.c file | annotate | diff | comparison | revisions 
--- a/mercurial/cext/revlog.c	Sun Jul 19 17:35:41 2020 +0900
+++ b/mercurial/cext/revlog.c	Sat Jul 18 18:13:41 2020 +0900
@@ -757,8 +757,11 @@
 	int rev, minrev = -1;
 	char *node;
 
-	if (!PySet_Check(roots))
+	if (!PySet_Check(roots)) {
+		PyErr_SetString(PyExc_TypeError,
+		                "roots must be a set of nodes");
 		return -2;
+	}
 	iterator = PyObject_GetIter(roots);
 	if (iterator == NULL)
 		return -2;
mercurial