branchcache: drop the unused `_verifyclosed`
authorPierre-Yves David <pierre-yves.david@octobus.net>
Sun, 25 Feb 2024 16:14:15 +0100
changeset 51456 19b2736c8e45
parent 51455 7a063dd9d64e
child 51457 c0d51565b501
branchcache: drop the unused `_verifyclosed` This code appears dead since its introduction about 5 years ago in this three consecutive commits: - 6578654916ae → introduce the method with two calls - 7c9d4cf23adf → remove first call - be5eeaf5c24a → remove second call o changeset: be5eeaf5c24a | user: Pulkit Goyal <pulkit@yandex-team.ru> | date: Fri Apr 05 15:57:09 2019 +0300 | summary: branchcache: don't verify closed nodes in _branchtip() | o changeset: 7c9d4cf23adf | user: Pulkit Goyal <pulkit@yandex-team.ru> | date: Fri Apr 05 15:56:33 2019 +0300 | summary: branchcache: don't verify closed nodes in iteropen() | o changeset: 6578654916ae | user: Pulkit Goyal <pulkit@yandex-team.ru> ~ date: Mon Apr 01 13:56:47 2019 +0300 summary: branchcache: lazily validate nodes from the branchmap
mercurial/branchmap.py
--- a/mercurial/branchmap.py	Mon Feb 26 15:46:24 2024 +0100
+++ b/mercurial/branchmap.py	Sun Feb 25 16:14:15 2024 +0100
@@ -438,8 +438,6 @@
 
         # Do we need to verify branch at all ?
         self._verify_node = verify_node
-        # whether closed nodes are verified or not
-        self._closedverified = False
         # branches for which nodes are verified
         self._verifiedbranches = set()
         self._hasnode = None
@@ -553,7 +551,6 @@
         # to hurt to overschedule
         other._delayed = self._delayed
         # also copy information about the current verification state
-        other._closedverified = self._closedverified
         other._verifiedbranches = set(self._verifiedbranches)
         return other
 
@@ -601,19 +598,6 @@
                 % stringutil.forcebytestr(inst)
             )
 
-    def _verifyclosed(self):
-        """verify the closed nodes we have"""
-        if not self._verify_node:
-            return
-        if self._closedverified:
-            return
-        assert self._hasnode is not None
-        for node in self._closednodes:
-            if not self._hasnode(node):
-                _unknownnode(node)
-
-        self._closedverified = True
-
     def _verifybranch(self, branch):
         """verify head nodes for the given branch."""
         if not self._verify_node: