Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
mail: add a TODO about proper mbox locking stable
authorMatt Harbison <matt_harbison@yahoo.com>
Tue, 20 Apr 2021 23:31:36 -0400
branchstable
changeset 46997 106402245301
parent 46996 8d2b62d716b0
child 46998 65d18001cfbf
mail: add a TODO about proper mbox locking Per @nbjoerg in IRC, the mbox isn't locked correctly. Differential Revision: https://phab.mercurial-scm.org/D10505
mercurial/mail.py file | annotate | diff | comparison | revisions 
--- a/mercurial/mail.py	Tue Apr 20 20:35:46 2021 +0200
+++ b/mercurial/mail.py	Tue Apr 20 23:31:36 2021 -0400
@@ -220,6 +220,7 @@
 
 def _mbox(mbox, sender, recipients, msg):
     '''write mails to mbox'''
+    # TODO: use python mbox library for proper locking
     with open(mbox, b'ab+') as fp:
         # Should be time.asctime(), but Windows prints 2-characters day
         # of month instead of one. Make them print the same thing.
mercurial