Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
dirstate: add comment on why we don't need to check if something is a dir/file
authorKyle Lippincott <spectral@google.com>
Wed, 08 Aug 2018 17:07:27 -0700
changeset 38959 0d032756e9bf
parent 38958 b9f94d67ea73
child 38960 d99468d2b09a
dirstate: add comment on why we don't need to check if something is a dir/file Differential Revision: https://phab.mercurial-scm.org/D4161
mercurial/dirstate.py file | annotate | diff | comparison | revisions 
--- a/mercurial/dirstate.py	Wed Aug 08 17:03:05 2018 -0700
+++ b/mercurial/dirstate.py	Wed Aug 08 17:07:27 2018 -0700
@@ -912,6 +912,11 @@
                         continue
                     raise
                 for f, kind, st in entries:
+                    # If we needed to inspect any files, visitentries would have
+                    # been 'this' or 'all', and we would have set it to None
+                    # above. If we have visitentries populated here, we don't
+                    # care about any files in this directory, so no need to
+                    # check the type of `f`.
                     if visitentries and f not in visitentries:
                         continue
                     if normalizefile:
mercurial