Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
procutil: use unbuffered stdout on Windows stable 4.6.2
authorSune Foldager <cryo@cyanite.org>
Mon, 25 Jun 2018 16:36:14 +0200
branchstable
changeset 38455 0b63a6743010
parent 38425 1322ae04d3d7
child 38523 77d1fa0fa2e1
procutil: use unbuffered stdout on Windows Windows doesn't support line buffering, treating it as fully buffered. This causes output of slow commands to stutter. We use unbuffered instead.
mercurial/utils/procutil.py file | annotate | diff | comparison | revisions 
--- a/mercurial/utils/procutil.py	Tue Jun 19 22:45:52 2018 +0900
+++ b/mercurial/utils/procutil.py	Mon Jun 25 16:36:14 2018 +0200
@@ -42,9 +42,13 @@
 
 # glibc determines buffering on first write to stdout - if we replace a TTY
 # destined stdout with a pipe destined stdout (e.g. pager), we want line
-# buffering
+# buffering (or unbuffered, on Windows)
 if isatty(stdout):
-    stdout = os.fdopen(stdout.fileno(), r'wb', 1)
+    if pycompat.iswindows:
+        # Windows doesn't support line buffering
+        stdout = os.fdopen(stdout.fileno(), r'wb', 0)
+    else:
+        stdout = os.fdopen(stdout.fileno(), r'wb', 1)
 
 if pycompat.iswindows:
     from .. import windows as platform
mercurial