safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:19:26 +0100
changeset 50552 037890ecaff5
parent 50551 b1fb4185e47c
child 50553 55886050a583
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/bundle2.py
--- a/mercurial/bundle2.py	Thu Feb 02 17:18:37 2023 +0100
+++ b/mercurial/bundle2.py	Thu Feb 02 17:19:26 2023 +0100
@@ -1234,7 +1234,7 @@
         # we only support fixed size data now.
         # This will be improved in the future.
         if util.safehasattr(self.data, 'next') or util.safehasattr(
-            self.data, b'__next__'
+            self.data, '__next__'
         ):
             buff = util.chunkbuffer(self.data)
             chunk = buff.read(preferedchunksize)