rust-filepatterns: add comment about Windows path handling As I replied to the Phabricator message, this is wrong. And I even suspect it wouldn't compile because of multiple type mismatches. I think, in Rust where type system is rock solid, we can live with UTF-8 strings except for the bottom storage layer and the top UI/command layer. We'll still have to get around undecodable characters not to be lost, but I think it's okay to drop such filenames from match result if they don't match in UTF-8 world, not in Latin-1 world.

     1

use std::path::Path;

     2

     3

pub fn get_path_from_bytes(bytes: &[u8]) -> &Path {

     4

    let os_str;

     5

    #[cfg(unix)]

     6

    {

     7

        use std::os::unix::ffi::OsStrExt;

     8

        os_str = std::ffi::OsStr::from_bytes(bytes);

     9

    }

    10

    #[cfg(windows)]

    11

    {

    12

        // TODO: convert from Windows MBCS (ANSI encoding) to WTF8.

    13

        // Perhaps, the return type would have to be Result<PathBuf>.

    14

        use std::os::windows::ffi::OsStrExt;

    15

        os_str = std::ffi::OsString::from_wide(bytes);

    16

    }

    17

    18

    Path::new(os_str)

    19

}