revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

Failed qimport of patches from files should cleanup by recording successfully

     2

imported patches in series file.

     3

     4

  $ echo "[extensions]" >> $HGRCPATH

     5

  $ echo "mq=" >> $HGRCPATH

     6

  $ hg init repo

     7

  $ cd repo

     8

  $ echo a > a

     9

  $ hg ci -Am'add a'

    10

  adding a

    11

  $ cat >b.patch<<EOF

    12

  > diff --git a/a b/a

    13

  > --- a/a

    14

  > +++ b/a

    15

  > @@ -1,1 +1,2 @@

    16

  >  a

    17

  > +b

    18

  > EOF

    19

    20

empty series

    21

    22

  $ hg qseries

    23

    24

qimport valid patch followed by invalid patch

    25

    26

  $ hg qimport b.patch fakepatch

    27

  adding b.patch to series file

    28

  abort: unable to read file fakepatch

    29

  [255]

    30

    31

valid patches before fail added to series

    32

    33

  $ hg qseries

    34

  b.patch

    35

    36

  $ hg pull -q -r 0 . # update phase

    37

  $ hg qimport -r 0

    38

  abort: revision 0 is not mutable

    39

  (see 'hg help phases' for details)

    40

  [255]

    41

    42

  $ cd ..