Fix zombie files in merge # HG changeset patch # User maf46@burn.cl.cam.ac.uk # Node ID 57667c9b93a5a743e4629d15a0e6bd76699130c3 # Parent d2994b5298fb20f87dc1d4747635b280db3c0526 Fix zombie files in merge Keir Fraser observed the following: > I made a small test case that illustrates the bug in merging changesets > with 'hg remove's in them: > > 1. Create a repository A containing files foo & bar. > 2. Create clone called B. > 3. A removes file bar, and commits this removal. > 4. B edits file foo, and commits this edit. > > Now, if B: > # hg pull ../A; hg update -m; hg commit > Then bar remains deleted. > > If A: > # hg pull ../B; hg update -m; hg commit > Then bar is resurrected! > > It looks as though, when you merge across a branch, any deletions in > your own branch are forgotten. > ... > Fixing this is a must, as zombie files are a real pain. :-) Keir later patched our local copy of hg as shown below, which fixes the problem. I've also enclosed a test which captures the test Keir outlined... Files deleted on a branch should not automatically reappear in a merge Patch notes: 1. The first chunk does not change behaviour, but cleans up the code to more closely match check of 'force' in the second chunk. I think it makes the code clearer. 2. The second chunk fixes two bugs -- i. If we choose to keep a remotely-changed locally-deleted file, then we need to 'get' that file. If we choose to delete it then no action need be taken (it is already deleted in the working manifest). Without this fix, choosing to delete would get a Python traceback. ii. The test for whether the file was remotely-created is insufficient. It is only true if f is not in the common ancestor. Otherwise the file was deleted locally, and should remain deleted. (this is the most important fix!) Index: hg/tests/test-merge6 ===================================================================

     1

#!/bin/sh -x

     2

     3

cat <<'EOF' > merge

     4

#!/bin/sh

     5

echo merging for `basename $1`

     6

EOF

     7

chmod +x merge

     8

export HGMERGE=./merge

     9

    10

mkdir A1

    11

cd A1

    12

hg init

    13

echo This is file foo1 > foo

    14

echo This is file bar1 > bar

    15

hg add foo bar

    16

hg commit -t "commit text" -d "0 0" -u user

    17

    18

cd ..

    19

hg clone A1 B1

    20

    21

cd A1

    22

rm bar

    23

hg remove bar

    24

hg commit -t "commit test" -d "0 0" -u user

    25

    26

cd ../B1

    27

echo This is file foo22 > foo

    28

hg commit -t "commit test" -d "0 0" -u user

    29

    30

cd ..

    31

hg clone A1 A2

    32

hg clone B1 B2

    33

    34

cd A1

    35

hg pull ../B1

    36

hg update -m

    37

hg commit -t "commit test" -d "0 0" -u user

    38

echo bar should remain deleted.

    39

hg manifest

    40

    41

cd ../B2

    42

hg pull ../A2

    43

hg update -m

    44

hg commit -t "commit test" -d "0 0" -u user

    45

echo bar should remain deleted.

    46

hg manifest