Mercurial Mercurial > mercurial / annotate
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
tests/test-check-code.t
author Thomas Arendsen Hein <thomas@intevation.de>
Wed, 29 Jun 2011 13:45:51 +0200
branchstable
changeset 14763 b071cd58af50
parent 13077 6b8d2ee24ce2
child 15281 aeeb2afcdc25
permissions -rw-r--r--
check-code: fix class style checking (with tests) - old-style classes were only checked for one-letter class names - add check for new-style classes with empty parent class, because this is not available in Python 2.4
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
12632
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
     1
 
  $ cat > correct.py <<EOF
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
     2
 
  > def toto(arg1, arg2):
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
     3
 
  >     del arg2
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
     4
 
  >     return (5 + 6, 9)
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
     5
 
  > EOF
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
     6
 
  $ cat > wrong.py <<EOF
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
     7
 
  > def toto( arg1, arg2):
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
     8
 
  >     del(arg2)
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
     9
 
  >     return ( 5+6, 9)
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    10
 
  > EOF
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    11
 
  $ cat > quote.py <<EOF
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    12
 
  > # let's use quote in comments
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    13
 
  > (''' ( 4x5 )
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    14
 
  > but """\\''' and finally''',
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    15
 
  > """let's fool checkpatch""", '1+2',
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    16
 
  > '"""', 42+1, """and
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    17
 
  > ( 4-1 ) """, "( 1+1 )\" and ")
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    18
 
  > a, '\\\\\\\\', "\\\\\\" x-2", "c-1"
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    19
 
  > EOF
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    20
 
  $ cat > non-py24.py <<EOF
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    21
 
  > # Using builtins that does not exist in Python 2.4
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    22
 
  > if any():
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    23
 
  >     x = all()
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    24
 
  >     y = format(x)
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    25
 
  >
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    26
 
  > # Do not complain about our own definition
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    27
 
  > def any(x):
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    28
 
  >     pass
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    29
 
  > EOF
14763
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    30
 
  $ cat > classstyle.py <<EOF
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    31
 
  > class newstyle_class(object):
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    32
 
  >     pass
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    33
 
  >
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    34
 
  > class oldstyle_class:
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    35
 
  >     pass
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    36
 
  >
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    37
 
  > class empty():
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    38
 
  >     pass
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    39
 
  >
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    40
 
  > no_class = 1:
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    41
 
  >     pass
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    42
 
  > EOF
12632
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    43
 
  $ check_code="$TESTDIR"/../contrib/check-code.py
14763
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    44
 
  $ "$check_code" ./wrong.py ./correct.py ./quote.py ./non-py24.py ./classstyle.py
12632
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    45
 
  ./wrong.py:1:
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    46
 
   > def toto( arg1, arg2):
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    47
 
   gratuitous whitespace in () or []
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    48
 
  ./wrong.py:2:
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    49
 
   >     del(arg2)
13077
6b8d2ee24ce2 coding style: fix yield used as a function
Thomas Arendsen Hein <thomas@jtah.de>
parents: 13026
diff changeset 
    50
 
   Python keyword is not a function
12632
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    51
 
  ./wrong.py:3:
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    52
 
   >     return ( 5+6, 9)
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    53
 
   missing whitespace in expression
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    54
 
   gratuitous whitespace in () or []
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    55
 
  ./quote.py:5:
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    56
 
   > '"""', 42+1, """and
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    57
 
   missing whitespace in expression
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    58
 
  ./non-py24.py:2:
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    59
 
   > if any():
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    60
 
   any/all/format not available in Python 2.4
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    61
 
  ./non-py24.py:3:
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    62
 
   >     x = all()
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    63
 
   any/all/format not available in Python 2.4
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    64
 
  ./non-py24.py:4:
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    65
 
   >     y = format(x)
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    66
 
   any/all/format not available in Python 2.4
14763
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    67
 
  ./classstyle.py:4:
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    68
 
   > class oldstyle_class:
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    69
 
   old-style class, use class foo(object)
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    70
 
  ./classstyle.py:7:
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    71
 
   > class empty():
b071cd58af50 check-code: fix class style checking (with tests)
Thomas Arendsen Hein <thomas@intevation.de>
parents: 13077
diff changeset 
    72
 
   class foo() not available in Python 2.4, use class foo(object)
12632
6c98107f787e tests: unify test-check-code
Brodie Rao <brodie@bitheap.org>
parents: 11822
diff changeset 
    73
 
  [1]
13026
53391819f195 check-code: catch Python 'is' comparing number or string literals
Adrian Buehlmann <adrian@cadifra.com>
parents: 12632
diff changeset 
    74
 












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    75


  $ cat > is-op.py <<EOF












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    76


  > # is-operator comparing number or string literal












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    77


  > x = None












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    78


  > y = x is 'foo'












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    79


  > y = x is "foo"












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    80


  > y = x is 5346












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    81


  > y = x is -6












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    82


  > y = x is not 'foo'












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    83


  > y = x is not "foo"












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    84


  > y = x is not 5346












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    85


  > y = x is not -6












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    86


  > EOF












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    87














53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    88


  $ "$check_code" ./is-op.py












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    89


  ./is-op.py:3:












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    90


   > y = x is 'foo'












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    91


   object comparison with literal












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    92


  ./is-op.py:4:












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    93


   > y = x is "foo"












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    94


   object comparison with literal












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    95


  ./is-op.py:5:












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    96


   > y = x is 5346












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    97


   object comparison with literal












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    98


  ./is-op.py:6:












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




    99


   > y = x is -6












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   100


   object comparison with literal












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   101


  ./is-op.py:7:












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   102


   > y = x is not 'foo'












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   103


   object comparison with literal












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   104


  ./is-op.py:8:












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   105


   > y = x is not "foo"












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   106


   object comparison with literal












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   107


  ./is-op.py:9:












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   108


   > y = x is not 5346












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   109


   object comparison with literal












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   110


  ./is-op.py:10:












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   111


   > y = x is not -6












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   112


   object comparison with literal












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   113


  [1]












53391819f195
check-code: catch Python 'is' comparing number or string literals



Adrian Buehlmann <adrian@cadifra.com>


parents: 
12632

diff
changeset




   114
















mercurial