largefiles: avoid unnecessary creation of .hg/largefiles when opening lfdirstate Previously, the directory '.hg/largefiles' would always be created if it didn't exist when the lfdirstate was opened. If there were no standin files, no dirstate file would be created in the directory. The end result was that enabling the largefiles extension globally, but not explicitly adding a largefile would result in the repository eventually sprouting this directory. Creation of this directory effectively changes readonly operations like summary and status into operations that require write access. Without write access, commands that would succeed without the extension loaded would abort with a surprising error when the extension is loaded, but not actively used: $ hg sum -R /tmp/thg --config extensions.largefiles= parent: 16541:00dc703d5aed repowidget: specify incoming bundle by plain file path to avoid url parsing branch: default abort: Permission denied: '/tmp/thg/.hg/largefiles' This change is simpler than changing the callers of openlfdirstate() to use the 'create' parameter that was introduced in ae57920ac188, and probably how that should have been implemented in the first place.

     1

  $ hg init test

     2

  $ cd test

     3

  $ echo foo>foo

     4

  $ hg addremove

     5

  adding foo

     6

  $ hg commit -m "1"

     7

     8

  $ hg verify

     9

  checking changesets

    10

  checking manifests

    11

  crosschecking files in changesets and manifests

    12

  checking files

    13

  1 files, 1 changesets, 1 total revisions

    14

    15

  $ hg clone . ../branch

    16

  updating to branch default

    17

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    18

  $ cd ../branch

    19

  $ hg co

    20

  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

    21

  $ echo bar>>foo

    22

  $ hg commit -m "2"

    23

    24

  $ cd ../test

    25

    26

  $ hg pull ../branch

    27

  pulling from ../branch

    28

  searching for changes

    29

  adding changesets

    30

  adding manifests

    31

  adding file changes

    32

  added 1 changesets with 1 changes to 1 files

    33

  (run 'hg update' to get a working copy)

    34

    35

  $ hg verify

    36

  checking changesets

    37

  checking manifests

    38

  crosschecking files in changesets and manifests

    39

  checking files

    40

  1 files, 2 changesets, 2 total revisions

    41

    42

  $ hg co

    43

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    44

    45

  $ cat foo

    46

  foo

    47

  bar

    48

    49

  $ hg manifest --debug

    50

  6f4310b00b9a147241b071a60c28a650827fb03d 644   foo

    51

    52

update to rev 0 with a date

    53

    54

  $ hg upd -d foo 0

    55

  abort: you can't specify a revision and a date

    56

  [255]

    57

    58

  $ cd ..