commands: make commit acquire locks before processing (issue4368) Before this patch, "hg commit" (process A) executes steps below: 1. get current branch heads via 'repo.branchheads()' - cache 'repo.changelog' 2. invoke 'repo.commit()' 3. acquire wlock - invalidate 'repo.dirstate' 4. access 'repo.dirstate' - re-read '.hg/dirstate' - check validity of parent revisions with 'repo.changelog' 5. invoke 'repo.commitctx()' 6. acquire store lock (slock) - invalidate 'repo.changelog' 7. do committing 8. release slock 9. release wlock 10. check new branch head (via 'cmdutil.commitstatus()') If acquisition of wlock at (3) above waits for another "hg commit" (process B) or so running parallelly to release wlock, process A causes creating orphan revision, because: - '.hg/dirstate' refers the revision, which is newly added by process B, as its parent - but already cached 'repo.changelog' doesn't contain such revision - therefore, validating parents of '.hg/dirstate' at (4) above replaces such revision with 'nullid' Then, process A creates "orphan" revision, of which parent is "null" revision. In addition to it, "created new head" may be shown at the end of process A unintentionally, if store is updated parallelly, because both getting branch heads (1) and checking new branch head (10) are executed outside slock scope. To avoid this issue, this patch makes "hg commit" acquire wlock and slock before processing. This patch resolves the issue between "hg commit" processes, but not one between "hg commit" and other commands. Subsequent patches resolve the latter. Even after this patch, there are still corner case problems below: - filecache may overlook changes of '.hg/dirstate', and it causes similar issue (see below for detail) https://bz.mercurial-scm.org/show_bug.cgi?id=4368#c10 - 3rd party extension may cause similar issue, if it directly uses 'repo.commit()' without acquisition of wlock and slock This can be fixed by acquisition of slock at the beginning of 'repo.commit()', but it seems suitable for "default" branch In fact, acquisition of slock itself is already introduced at "default" branch by 4414d500604f, but acquisition is not at the beginning of 'repo.commit()'. This patch also changes some tests: - test-fncache.t needs this tricky wrapping, to release (= forced failure of) wlock certainly - order of "hg commit" output is changed by widening scope of locks, because some hooks are fired after releasing wlock

     1

import os, sys, time

     2

from mercurial import hg, ui, commands, util

     3

     4

TESTDIR = os.environ["TESTDIR"]

     5

BUNDLEPATH = os.path.join(TESTDIR, 'bundles', 'test-no-symlinks.hg')

     6

     7

# only makes sense to test on os which supports symlinks

     8

if not getattr(os, "symlink", False):

     9

    sys.exit(80) # SKIPPED_STATUS defined in run-tests.py

    10

    11

u = ui.ui()

    12

# hide outer repo

    13

hg.peer(u, {}, '.', create=True)

    14

    15

# clone with symlink support

    16

hg.clone(u, {}, BUNDLEPATH, 'test0')

    17

    18

repo = hg.repository(u, 'test0')

    19

    20

# wait a bit, or the status call wont update the dirstate

    21

time.sleep(1)

    22

commands.status(u, repo)

    23

    24

# now disable symlink support -- this is what os.symlink would do on a

    25

# non-symlink file system

    26

def symlink_failure(src, dst):

    27

    raise OSError(1, "Operation not permitted")

    28

os.symlink = symlink_failure

    29

    30

# dereference links as if a Samba server has exported this to a

    31

# Windows client

    32

for f in 'test0/a.lnk', 'test0/d/b.lnk':

    33

    os.unlink(f)

    34

    fp = open(f, 'wb')

    35

    fp.write(util.readfile(f[:-4]))

    36

    fp.close()

    37

    38

# reload repository

    39

u = ui.ui()

    40

repo = hg.repository(u, 'test0')

    41

commands.status(u, repo)

    42

    43

# try cloning a repo which contains symlinks

    44

u = ui.ui()

    45

hg.clone(u, {}, BUNDLEPATH, 'test1')