status: prefer relative paths in Rust code … when the repository root is under the current directory, so the kernel needs to traverse fewer directory in every call to `read_dir` or `symlink_metadata`. Better yet would be to use libc functions like `openat` and `fstatat` to remove such repeated traversals entirely, but the standard library does not provide APIs based on those. Maybe with a crate like https://crates.io/crates/openat instead? Benchmarks of `rhg status` show that this patch is neutral in some configurations, and makes the command up to ~20% faster in others. Below is semi-arbitrary subset of results. The four numeric columns are: time (in seconds) with this changeset’s parent, time with this changeset, time difference (negative is better), time ratio (less than 1 is better). ``` mercurial-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.0061 -> 0.0059: -0.0002 (0.97) mercurial-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0029 -> 0.0028: -0.0001 (0.97) mozilla-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.2110 -> 0.2102: -0.0007 (1.00) mozilla-dirstate-v2 | default-copies-clean.ignored.pbr | 0.0489 -> 0.0401: -0.0088 (0.82) mozilla-dirstate-v2 | default-copies-clean.no-iu.pbr | 0.0479 -> 0.0393: -0.0085 (0.82) mozilla-dirstate-v2 | default-copies-large.all.pbr | 0.1262 -> 0.1210: -0.0051 (0.96) mozilla-dirstate-v2 | default-copies-small.ignored-unknown.pbr | 0.1262 -> 0.1200: -0.0062 (0.95) mozilla-dirstate-v2 | default-copies-small.ignored.pbr | 0.0536 -> 0.0417: -0.0119 (0.78) mozilla-dirstate-v2 | default-copies-small.no-iu.pbr | 0.0482 -> 0.0393: -0.0089 (0.81) mozilla-dirstate-v2 | default-plain-clean.ignored.pbr | 0.0518 -> 0.0402: -0.0116 (0.78) mozilla-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0481 -> 0.0392: -0.0088 (0.82) mozilla-dirstate-v2 | default-plain-large.all.pbr | 0.1271 -> 0.1218: -0.0052 (0.96) mozilla-dirstate-v2 | default-plain-small.ignored-unknown.pbr | 0.1225 -> 0.1202: -0.0022 (0.98) mozilla-dirstate-v2 | default-plain-small.ignored.pbr | 0.0510 -> 0.0418: -0.0092 (0.82) mozilla-dirstate-v2 | default-plain-small.no-iu.pbr | 0.0480 -> 0.0394: -0.0086 (0.82) netbeans-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.1442 -> 0.1422: -0.0020 (0.99) netbeans-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0325 -> 0.0282: -0.0043 (0.87) ``` Differential Revision: https://phab.mercurial-scm.org/D12175

     1

  $ hg init

     2

  $ echo a > a

     3

  $ hg ci -Am0

     4

  adding a

     5

     6

  $ hg -q clone . foo

     7

     8

  $ touch .hg/store/journal

     9

    10

  $ echo foo > a

    11

  $ hg ci -Am0

    12

  abort: abandoned transaction found

    13

  (run 'hg recover' to clean up transaction)

    14

  [255]

    15

    16

  $ hg recover

    17

  rolling back interrupted transaction

    18

  (verify step skipped, run `hg verify` to check your repository content)

    19

    20

recover, explicit verify

    21

    22

  $ touch .hg/store/journal

    23

  $ hg ci -Am0

    24

  abort: abandoned transaction found

    25

  (run 'hg recover' to clean up transaction)

    26

  [255]

    27

  $ hg recover --verify

    28

  rolling back interrupted transaction

    29

  checking changesets

    30

  checking manifests

    31

  crosschecking files in changesets and manifests

    32

  checking files

    33

  checked 1 changesets with 1 changes to 1 files

    34

    35

recover, no verify

    36

    37

  $ touch .hg/store/journal

    38

  $ hg ci -Am0

    39

  abort: abandoned transaction found

    40

  (run 'hg recover' to clean up transaction)

    41

  [255]

    42

  $ hg recover --no-verify

    43

  rolling back interrupted transaction

    44

  (verify step skipped, run `hg verify` to check your repository content)

    45

    46

    47

Check that zero-size journals are correctly aborted:

    48

    49

#if unix-permissions no-root

    50

  $ hg bundle -qa repo.hg

    51

  $ chmod -w foo/.hg/store/00changelog.i

    52

    53

  $ hg -R foo unbundle repo.hg

    54

  adding changesets

    55

  abort: Permission denied: '$TESTTMP/foo/.hg/store/.00changelog.i-*' (glob)

    56

  [255]

    57

    58

  $ if test -f foo/.hg/store/journal; then echo 'journal exists :-('; fi

    59

#endif

    60