run-tests: report tests that exception occurred in We now record the test that an exception occurred in. We put this information to use by aggregating the count of failures in each test. For each exception, the exception report now prints the total number of tests having that exception and the test with the least number of exceptions exhibiting that failure. The exception list is now sorted by (total count, tests impacted, count of failures in least failing test). This allows us to: * Assess how widespread a failure is. Some exceptions occur a lot in a few tests. Others occur over many tests. * Easily run a test exhibiting an exception without having to find a failure in test output. * Find and fix low hanging fruit (e.g. exceptions that are the only failure in a test). Here's an example of the new output: 199 (4 tests) /home/gps/src/hg/hgext/blackbox.py:191: %b requires a bytes-like object, or an object that implements __bytes__, not 'str' (test-devel-warnings.t - 1 total) 142 (19 tests) /home/gps/src/hg/hgext/mq.py:655: list indices must be integers or slices, not bytes (test-hardlinks.t - 1 total) 140 (20 tests) /home/gps/src/hg/mercurial/patch.py:296: string argument expected, got 'bytes' (test-audit-subrepo.t - 1 total) 101 (15 tests) /home/gps/src/hg/hgext/convert/convcmd.py:60: encode() argument 1 must be str, not bytes (test-convert-clonebranches.t - 1 total) 90 (2 tests) /home/gps/src/hg/hgext/mq.py:456: can't concat str to bytes (test-mq-qqueue.t - 1 total) 87 (2 tests) /home/gps/src/hg/mercurial/branchmap.py:380: %b requires a bytes-like object, or an object that implements __bytes__, not 'FileNotFoundError' (test-branches.t - 2 total) 85 (22 tests) /home/gps/src/hg/mercurial/sshpeer.py:223: cannot convert 'UUID' object to bytes (test-bundle2-pushback.t - 1 total) 1 (1 tests) /home/gps/src/hg/mercurial/formatter.py:254: %b requires a bytes-like object, or an object that implements __bytes__, not 'str' (test-debugextensions.t - 2 total) 1 (1 tests) /home/gps/src/hg/hgext/convert/convcmd.py:420: startswith first arg must be str or a tuple of str, not bytes (test-convert-authormap.t - 2 total) 1 (1 tests) /home/gps/src/hg/mercurial/revlog.py:797: '>=' not supported between instances of 'NoneType' and 'int' (test-unionrepo.t - 1 total) 1 (1 tests) /home/gps/src/hg/hgext/show.py:129: %b requires a bytes-like object, or an object that implements __bytes__, not 'str' (test-show.t - 1 total) Differential Revision: https://phab.mercurial-scm.org/D2138

     1

# logexceptions.py - Write files containing info about Mercurial exceptions

     2

#

     3

# Copyright 2017 Matt Mackall <mpm@selenic.com>

     4

#

     5

# This software may be used and distributed according to the terms of the

     6

# GNU General Public License version 2 or any later version.

     7

     8

from __future__ import absolute_import

     9

    10

import inspect

    11

import os

    12

import sys

    13

import traceback

    14

import uuid

    15

    16

from mercurial import (

    17

    dispatch,

    18

    extensions,

    19

)

    20

    21

def handleexception(orig, ui):

    22

    res = orig(ui)

    23

    24

    if not ui.environ.get(b'HGEXCEPTIONSDIR'):

    25

        return res

    26

    27

    dest = os.path.join(ui.environ[b'HGEXCEPTIONSDIR'],

    28

                        str(uuid.uuid4()).encode('ascii'))

    29

    30

    exc_type, exc_value, exc_tb = sys.exc_info()

    31

    32

    stack = []

    33

    tb = exc_tb

    34

    while tb:

    35

        stack.append(tb)

    36

        tb = tb.tb_next

    37

    stack.reverse()

    38

    39

    hgframe = 'unknown'

    40

    hgline = 'unknown'

    41

    42

    # Find the first Mercurial frame in the stack.

    43

    for tb in stack:

    44

        mod = inspect.getmodule(tb)

    45

        if not mod.__name__.startswith(('hg', 'mercurial')):

    46

            continue

    47

    48

        frame = tb.tb_frame

    49

    50

        try:

    51

            with open(inspect.getsourcefile(tb), 'r') as fh:

    52

                hgline = fh.readlines()[frame.f_lineno - 1].strip()

    53

        except (IndexError, OSError):

    54

            pass

    55

    56

        hgframe = '%s:%d' % (frame.f_code.co_filename, frame.f_lineno)

    57

        break

    58

    59

    primary = traceback.extract_tb(exc_tb)[-1]

    60

    primaryframe = '%s:%d' % (primary.filename, primary.lineno)

    61

    62

    with open(dest, 'wb') as fh:

    63

        parts = [

    64

            str(exc_value),

    65

            primaryframe,

    66

            hgframe,

    67

            hgline,

    68

            ui.environ[b'TESTNAME'].decode('utf-8', 'replace'),

    69

        ]

    70

        fh.write(b'\0'.join(p.encode('utf-8', 'replace') for p in parts))

    71

    72

def extsetup(ui):

    73

    extensions.wrapfunction(dispatch, 'handlecommandexception',

    74

                            handleexception)