wireproto: overhaul iterating batcher code (API) The remote batching code is difficult to read. Let's improve it. As part of the refactor, the future returned by method calls on batchiter() instances is now populated. However, you still need to consume the results() generator for the future to be set. But at least now we can stuff the future somewhere and not have to worry about aligning method call order with result order since you can use a future to hold the result. Also as part of the change, we now verify that @batchable generators yield exactly 2 values. In other words, we enforce their API. The non-iter batcher has been unused since b6e71f8af5b8. And to my surprise we had no explicit unit test coverage of it! test-batching.py has been overhauled to use the iterating batcher. Since the iterating batcher doesn't allow non-batchable method calls nor local calls, tests have been updated to reflect reality. The iterating batcher has been used for multiple releases apparently without major issue. So this shouldn't cause alarm. .. api:: @peer.batchable functions must now yield exactly 2 values Differential Revision: https://phab.mercurial-scm.org/D319

     1

     2

== Local

     3

Ready.

     4

Un and Deux

     5

Eins und Zwei

     6

One and Two

     7

Eins und Zwei

     8

Uno und Due

     9

proper end of results generator

    10

    11

== Remote

    12

Ready.

    13

REQ: foo?one=Vo&two=Efvy

    14

  -> Vo!boe!Efvy

    15

Un and Deux

    16

REQ: bar?b=Fjot&a=[xfj

    17

  -> Fjot!voe![xfj

    18

Eins und Zwei

    19

REQ: batch?cmds=foo:one=Pof,two=Uxp;bar:b=Fjot,a=[xfj;bar:b=Vop,a=Evf

    20

  -> Pof!boe!Uxp;Fjot!voe![xfj;Vop!voe!Evf

    21

One and Two

    22

Eins und Zwei

    23

Uno und Due

    24

proper end of results generator

    25

Attempted to batch a non-batchable call to 'greet'

    26

Attempted to batch a non-batchable call to 'hello'