phases: rework the logic of _pushdiscoveryphase to bound complexity This rework the various graph traversal in _pushdiscoveryphase to keep the complexity in check. This is done though a couple of things: - first, limiting the space we have to explore, for example, if we are not in publishing push, we don't need to consider remote draft roots that are also draft locally, as there is nothing to be moved there. - avoid unbounded descendant computation, and use the faster "rev between" computation. This provide a massive boost to performance when exchanging with repository with a massive amount of draft, like mozilla-try: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 20.346590 seconds after: 11.232059 seconds (-38.15%, -7.48 seconds) ## benchmark.variants.revs = any-100-extra-rev before: 24.752051 seconds after: 15.367412 seconds (-37.91%, -9.38 seconds) After this changes, the push operation is still quite too slow. Some of this can be attributed to general phases slowness (reading all the roots from disk for example) and other know slowness (not using persistent-nodemap, branchmap, tags, etc. We are also working on them, but with this series, phase discovery during push no longer showing up in profile and this is a pretty nice and bit low-hanging fruit out of the way. ### (same case as the above) # benchmark.variants.revs = any-1-extra-rev pre-%ln-change: 44.235070 this-changeset: 11.232059 seconds (-74.61%, -33.00 seconds) # benchmark.variants.revs = any-100-extra-rev pre-%ln-change: 49.234697 this-changeset: 15.367412 seconds (-68.79%, -33.87 seconds) Note that with this change, the `hg push` performance is now much closer to the `hg pull` performance, even it still lagging behind a bit. (and the overall performance are still too slow). ### data-env-vars.name = mozilla-try-2023-03-22-ds2-pnm # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default # bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 6.517450 hg.command.push: 11.219888 ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 10.160991 hg.command.push: 14.251107 ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.577772 hg.command.push: 11.232059 ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.152976 hg.command.push: 15.367412 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.731982 hg.command.push: 11.178751 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.184236 hg.command.push: 15.620843

     1

# A simple script for opening merge conflicts in editor

     2

# A loose translation of contrib/editmerge to powershell

     3

# Please make sure that both editmergeps.bat and editmerge.ps1 are available

     4

# via %PATH% and use the following Mercurial settings to enable it

     5

#

     6

# [ui]

     7

# editmergeps

     8

# editmergeps.args=$output

     9

# editmergeps.check=changed

    10

# editmergeps.premerge=keep

    11

    12

$file=$args[0]

    13

    14

function Get-Lines

    15

{

    16

  Select-String "^<<<<<<" $file | % {"$($_.LineNumber)"}

    17

}

    18

    19

$ed = $Env:HGEDITOR;

    20

if ($ed -eq $nil)

    21

{

    22

  $ed = $Env:VISUAL;

    23

}

    24

if ($ed -eq $nil)

    25

{

    26

  $ed = $Env:EDITOR;

    27

}

    28

if ($ed -eq $nil)

    29

{

    30

  $ed = $(hg showconfig ui.editor);

    31

}

    32

if ($ed -eq $nil)

    33

{

    34

  Write-Error "merge failed - unable to find editor"

    35

  exit 1

    36

}

    37

    38

if (($ed -eq "vim") -or ($ed -eq "emacs") -or `

    39

    ($ed -eq "nano") -or ($ed -eq "notepad++"))

    40

{

    41

  $lines = Get-Lines

    42

  $firstline = if ($lines.Length -gt 0) { $lines[0] } else { $nil }

    43

  $previousline = $nil;

    44

    45

    46

  # open the editor to the first conflict until there are no more

    47

  # or the user stops editing the file

    48

  while (($firstline -ne $nil) -and ($firstline -ne $previousline))

    49

  {

    50

    if ($ed -eq "notepad++")

    51

    {

    52

        $linearg = "-n$firstline"

    53

    }

    54

    else

    55

    {

    56

        $linearg = "+$firstline"

    57

    }

    58

    59

    Start-Process -Wait -NoNewWindow $ed $linearg,$file

    60

    $previousline = $firstline

    61

    $lines = Get-Lines

    62

    $firstline = if ($lines.Length -gt 0) { $lines[0] } else { $nil }

    63

  }

    64

}

    65

else

    66

{

    67

  & "$ed" $file

    68

}

    69

    70

$conflicts=Get-Lines

    71

if ($conflicts.Length -ne 0)

    72

{

    73

  Write-Output "merge failed - resolve the conflicts (line $conflicts) then use 'hg resolve --mark'"

    74

  exit 1

    75

}

    76

    77

exit 0

    78