MUC: Return a friendly textual error when trying to speak without voice
I spend several minutes confused over where the bug was until I
remembered I had set myself as visitor in the previous debug session.
This would have helped.
--- a/plugins/muc/muc.lib.lua Tue Dec 07 21:43:36 2021 +0100
+++ b/plugins/muc/muc.lib.lua Wed Dec 08 16:40:51 2021 +0100
@@ -1218,7 +1218,8 @@
event.origin.send(st.error_reply(event.stanza, "cancel", "not-acceptable", "You are not currently connected to this chat"));
return true;
elseif role_rank <= valid_roles.visitor then
- event.origin.send(st.error_reply(event.stanza, "auth", "forbidden"));
+ event.origin.send(st.error_reply(event.stanza, "auth", "forbidden",
+ "You do not currently have permission to speak in this chat"));
return true;
end
end, 50);