mod_disco: Advertise disco#info and #items on bare JIDs to fix #1664 0.12
authorKim Alvefur <zash@zash.se>
Sun, 17 Dec 2023 18:55:14 +0100
branch0.12
changeset 13412 d7857ef7843a
parent 13382 db30ffbf2090
child 13413 95d8875c90dc
child 13449 360e05f33835
mod_disco: Advertise disco#info and #items on bare JIDs to fix #1664 Having to add these in *there* places seems less than ideal. I would also think that advertising disco#info is a bit redundant, since it is a requirement for everything in XMPP and if it was missing you would get an error back.
plugins/mod_disco.lua
spec/scansion/disco_self.scs
--- a/plugins/mod_disco.lua	Wed Aug 23 12:18:34 2023 +0200
+++ b/plugins/mod_disco.lua	Sun Dec 17 18:55:14 2023 +0100
@@ -172,6 +172,8 @@
 	if not stanza.attr.to or (expose_admins and is_admin) or is_contact_subscribed(username, module.host, jid_bare(stanza.attr.from)) then
 		if node and node ~= "" then
 			local reply = st.reply(stanza):tag('query', {xmlns='http://jabber.org/protocol/disco#info', node=node});
+			reply:tag("feature", { var = "http://jabber.org/protocol/disco#info" }):up();
+			reply:tag("feature", { var = "http://jabber.org/protocol/disco#items" }):up();
 			if not reply.attr.from then reply.attr.from = origin.username.."@"..origin.host; end -- COMPAT To satisfy Psi when querying own account
 			local node_event = { origin = origin, stanza = stanza, reply = reply, node = node, exists = false};
 			local ret = module:fire_event("account-disco-info-node", node_event);
@@ -192,6 +194,8 @@
 		else
 			reply:tag('identity', {category='account', type='registered'}):up();
 		end
+		reply:tag("feature", { var = "http://jabber.org/protocol/disco#info" }):up();
+		reply:tag("feature", { var = "http://jabber.org/protocol/disco#items" }):up();
 		module:fire_event("account-disco-info", { origin = origin, reply = reply });
 		origin.send(reply);
 		return true;
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/spec/scansion/disco_self.scs	Sun Dec 17 18:55:14 2023 +0100
@@ -0,0 +1,26 @@
+# Basic login and initial presence
+
+[Client] Romeo
+	jid: discoverer@localhost
+	password: password
+
+---------
+
+Romeo connects
+
+Romeo sends:
+	<iq type="get" id="info1">
+		<query xmlns="http://jabber.org/protocol/disco#info"/>
+	</iq>
+
+Romeo receives:
+	<iq type="result" id="info1">
+		<query xmlns="http://jabber.org/protocol/disco#info" scansion:strict="false">
+			<identity xmlns="http://jabber.org/protocol/disco#info" category="account" type="registered"/>
+			<feature var="http://jabber.org/protocol/disco#info"/>
+			<feature var="http://jabber.org/protocol/disco#items"/>
+		</query>
+	</iq>
+
+Romeo disconnects
+