# HG changeset patch # User Matthew Wild # Date 1413309308 -3600 # Node ID e4b998ffc92249ea96716ab878f961f03769339d # Parent acae6289e0a6d7bc5809c134af1e98a3b8783988 certmanager, net.http: Disable SSLv3 by default diff -r acae6289e0a6 -r e4b998ffc922 core/certmanager.lua --- a/core/certmanager.lua Tue Oct 14 10:58:11 2014 +0100 +++ b/core/certmanager.lua Tue Oct 14 18:55:08 2014 +0100 @@ -33,7 +33,7 @@ local default_ssl_config = configmanager.get("*", "ssl"); local default_capath = "/etc/ssl/certs"; local default_verify = (ssl and ssl.x509 and { "peer", "client_once", }) or "none"; -local default_options = { "no_sslv2", "cipher_server_preference", luasec_has_noticket and "no_ticket" or nil }; +local default_options = { "no_sslv2", "no_sslv3", "cipher_server_preference", luasec_has_noticket and "no_ticket" or nil }; local default_verifyext = { "lsec_continue", "lsec_ignore_purpose" }; if ssl and not luasec_has_verifyext and ssl.x509 then diff -r acae6289e0a6 -r e4b998ffc922 net/http.lua --- a/net/http.lua Tue Oct 14 10:58:11 2014 +0100 +++ b/net/http.lua Tue Oct 14 18:55:08 2014 +0100 @@ -175,7 +175,7 @@ local sslctx = false; if using_https then - sslctx = ex and ex.sslctx or { mode = "client", protocol = "sslv23", options = { "no_sslv2" } }; + sslctx = ex and ex.sslctx or { mode = "client", protocol = "sslv23", options = { "no_sslv2", "no_sslv3" } }; end req.handler, req.conn = assert(server.wrapclient(conn, host, port_number, listener, "*a", sslctx));