# HG changeset patch # User Jonas Schäfer # Date 1640554320 -3600 # Node ID 7ba68669625000560700ae9ffe302b121ba9e637 # Parent 50795249b7be9df4a50993027f0c8314ca0feb76 openmetrics/histograms: fix incorrect condition for bucketing The buckets thresholds are to be taken as "less than or equal to". The condition as written in the code did only "less than", not "less than or equal to". That's fixed now. diff -r 50795249b7be -r 7ba686696250 util/statistics.lua --- a/util/statistics.lua Sun Dec 26 16:26:36 2021 +0100 +++ b/util/statistics.lua Sun Dec 26 22:32:00 2021 +0100 @@ -102,7 +102,7 @@ function histogram_metric_mt:sample(value) -- According to the I-D, values must be part of all buckets for i, bucket in pairs(self) do - if "number" == type(i) and bucket.threshold > value then + if "number" == type(i) and bucket.threshold >= value then bucket.count = bucket.count + 1 end end diff -r 50795249b7be -r 7ba686696250 util/statsd.lua --- a/util/statsd.lua Sun Dec 26 16:26:36 2021 +0100 +++ b/util/statsd.lua Sun Dec 26 22:32:00 2021 +0100 @@ -115,7 +115,7 @@ function histogram_metric_mt:sample(value) -- According to the I-D, values must be part of all buckets for i, bucket in pairs(self) do - if "number" == type(i) and bucket.threshold > value then + if "number" == type(i) and bucket.threshold >= value then bucket.count = bucket.count + 1 self._impl:push_counter_delta(bucket._full_name, 1) end