# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1690375176 -7200
# Node ID 5884d58707fac2af2a2bf4516e091217e6999b48
# Parent  db433ed3135c6cc4c394c75060a3ca8706cc8f6a
mod_http: Generate URL from configuration in prosodyctl

This removes the need to configure e.g. http_external_url or similar
settings in order to get correct URLs out of prosodyctl, as the API
depends on portmanager to know the actual ports that are used.

diff -r db433ed3135c -r 5884d58707fa plugins/mod_http.lua
--- a/plugins/mod_http.lua	Tue Jul 25 12:35:11 2023 +0200
+++ b/plugins/mod_http.lua	Wed Jul 26 14:39:36 2023 +0200
@@ -82,6 +82,7 @@
 
 	local external_url = url_parse(module:get_option_string("http_external_url"));
 	if external_url and mode ~= "internal" then
+		-- Current URL does not depend on knowing which ports are used, only configuration.
 		local url = {
 			scheme = external_url.scheme;
 			host = external_url.host;
@@ -93,6 +94,36 @@
 		return url_build(url);
 	end
 
+	if prosody.process_type ~= "prosody" then
+		-- We generally don't open ports outside of Prosody, so we can't rely on
+		-- portmanager to tell us which ports and services are used and derive the
+		-- URL from that, so instead we derive it entirely from configuration.
+		local https_ports = module:get_option_array("https_ports", { 5281 });
+		local scheme = "https";
+		local port = tonumber(https_ports[1]);
+		if not port then
+			-- https is disabled and no http_external_url set
+			scheme = "http";
+			local http_ports = module:get_option_array("http_ports", { 5280 });
+			port = tonumber(http_ports[1]);
+			if not port then
+				return "http://disabled.invalid/";
+			end
+		end
+
+		local url = {
+			scheme = scheme;
+			host = module:get_option_string("http_host", module.global and module:get_option_string("http_default_host") or module.host);
+			port = port;
+			path = get_base_path(module, app_name, default_path or "/" .. app_name);
+		}
+		if ports_by_scheme[url.scheme] == url.port then
+			url.port = nil
+		end
+		return url_build(url);
+	end
+
+	-- Use portmanager to find the actual port of https or http services
 	local services = portmanager.get_active_services();
 	local http_services = services:get("https") or services:get("http") or {};
 	for interface, ports in pairs(http_services) do -- luacheck: ignore 213/interface