# HG changeset patch # User Kim Alvefur # Date 1624308623 -7200 # Node ID 4c0802b526732907230fd3aba6bbde476e69042b # Parent d2a9aa1c7ac8f06069b9767a038d16e3150768ab mod_bosh,mod_websocket: Make into global-shared modules (...again) Global modules aren't quite considered loaded onto hosts, which causes confusion in some cases. They are also reported in the log as being served on http://*:5280/foo which is also a bit confusing, and can't be clicked. Global modules also have to have their paths configured in the global section, which could be confusing and unexpected. This global+shared method should be the best of both worlds. diff -r d2a9aa1c7ac8 -r 4c0802b52673 plugins/mod_bosh.lua --- a/plugins/mod_bosh.lua Mon Sep 06 23:21:25 2021 +0200 +++ b/plugins/mod_bosh.lua Mon Jun 21 22:50:23 2021 +0200 @@ -543,13 +543,17 @@ }) or "This is the Prosody BOSH endpoint."; end -module:depends("http"); -module:provides("http", { - default_path = "/http-bind"; - route = { - ["GET"] = GET_response; - ["GET /"] = GET_response; - ["POST"] = handle_POST; - ["POST /"] = handle_POST; - }; -}); +function module.add_host(module) + module:depends("http"); + module:provides("http", { + default_path = "/http-bind"; + route = { + ["GET"] = GET_response; + ["GET /"] = GET_response; + ["POST"] = handle_POST; + ["POST /"] = handle_POST; + }; + }); +end + +module:add_host(); diff -r d2a9aa1c7ac8 -r 4c0802b52673 plugins/mod_websocket.lua --- a/plugins/mod_websocket.lua Mon Sep 06 23:21:25 2021 +0200 +++ b/plugins/mod_websocket.lua Mon Jun 21 22:50:23 2021 +0200 @@ -348,18 +348,20 @@ end end -module:hook("c2s-read-timeout", keepalive, -0.9); - -module:depends("http"); -module:provides("http", { - name = "websocket"; - default_path = "xmpp-websocket"; - route = { - ["GET"] = handle_request; - ["GET /"] = handle_request; - }; -}); - function module.add_host(module) module:hook("c2s-read-timeout", keepalive, -0.9); + + module:depends("http"); + module:provides("http", { + name = "websocket"; + default_path = "xmpp-websocket"; + route = { + ["GET"] = handle_request; + ["GET /"] = handle_request; + }; + }); + + module:hook("c2s-read-timeout", keepalive, -0.9); end + +module:add_host();