Matthew Wild <mwild1@gmail.com> [Wed, 15 Jun 2022 14:22:26 +0100] rev 12647
teal-src: update module.d.tl with new access control methods
Matthew Wild <mwild1@gmail.com> [Wed, 15 Jun 2022 12:15:01 +0100] rev 12646
Switch to a new role-based authorization framework, removing is_admin()
We began moving away from simple "is this user an admin?" permission checks
before 0.12, with the introduction of mod_authz_internal and the ability to
dynamically change the roles of individual users.
The approach in 0.12 still had various limitations however, and apart from
the introduction of roles other than "admin" and the ability to pull that info
from storage, not much actually changed.
This new framework shakes things up a lot, though aims to maintain the same
functionality and behaviour on the surface for a default Prosody
configuration. That is, if you don't take advantage of any of the new
features, you shouldn't notice any change.
The biggest change visible to developers is that usermanager.is_admin() (and
the auth provider is_admin() method) have been removed. Gone. Completely.
Permission checks should now be performed using a new module API method:
module:may(action_name, context)
This method accepts an action name, followed by either a JID (string) or
(preferably) a table containing 'origin'/'session' and 'stanza' fields (e.g.
the standard object passed to most events). It will return true if the action
should be permitted, or false/nil otherwise.
Modules should no longer perform permission checks based on the role name.
E.g. a lot of code previously checked if the user's role was prosody:admin
before permitting some action. Since many roles might now exist with similar
permissions, and the permissions of prosody:admin may be redefined
dynamically, it is no longer suitable to use this method for permission
checks. Use module:may().
If you start an action name with ':' (recommended) then the current module's
name will automatically be used as a prefix.
To define a new permission, use the new module API:
module:default_permission(role_name, action_name)
module:default_permissions(role_name, { action_name[, action_name...] })
This grants the specified role permission to execute the named action(s) by
default. This may be overridden via other mechanisms external to your module.
The built-in roles that developers should use are:
- prosody:user (normal user)
- prosody:admin (host admin)
- prosody:operator (global admin)
The new prosody:operator role is intended for server-wide actions (such as
shutting down Prosody).
Finally, all usage of is_admin() in modules has been fixed by this commit.
Some of these changes were trickier than others, but no change is expected to
break existing deployments.
EXCEPT: mod_auth_ldap no longer supports the ldap_admin_filter option. It's
very possible nobody is using this, but if someone is then we can later update
it to pull roles from LDAP somehow.
Matthew Wild <mwild1@gmail.com> [Wed, 15 Jun 2022 11:47:39 +0100] rev 12645
mod_saslauth: Rename field from 'scope'->'role'
The 'scope' term derives from OAuth, and represents a bundle of permissions.
We're now setting on the term 'role' for a bundle of permissions.
This change does not affect any public modules I'm aware of.
Matthew Wild <mwild1@gmail.com> [Wed, 15 Jun 2022 11:37:09 +0100] rev 12644
util.session: Add role management methods
Kim Alvefur <zash@zash.se> [Fri, 19 Aug 2022 14:24:31 +0200] rev 12643
net.connect: Clear TODO for Happy Eyeballs / RFC 8305, close #1246
Gotta have the DOAP references!
Matthew Wild <mwild1@gmail.com> [Thu, 18 Aug 2022 15:43:16 +0100] rev 12642
Merge 0.12->trunk
Kim Alvefur <zash@zash.se> [Mon, 15 Aug 2022 18:56:22 +0200] rev 12641
mod_admin_shell: Switch names for user role management commands
user:roles() does not convey that this is the mutating command, it
should have been called setroles from the start but wasn't due to lack
of foresight. This has to accidentally removing roles when wanting to
show them.
Kim Alvefur <zash@zash.se> [Wed, 17 Aug 2022 19:04:30 +0200] rev 12640
util.stanza: Add method for extracting a single attribute value
Sometimes you only care about a single attribute, but the child tag
itself may be optional, leading to needing `tag and tag.attr.foo` or
`stanza:find("tag@foo")`.
The `:find()` method is fairly complex, so avoiding it for this kind of
simpler use case is a win.
Kim Alvefur <zash@zash.se> [Mon, 15 Aug 2022 16:35:14 +0200] rev 12639
mod_time: Remove obsolete XEP-0090 support
Deprecated even before Prosody even started, obsolete for over a decade.
Kim Alvefur <zash@zash.se> [Wed, 17 Aug 2022 18:41:35 +0200] rev 12638
util.datetime: Update Teal interface description
Integers were required before, now any number should work.