Kim Alvefur <zash@zash.se> [Sat, 10 Apr 2021 14:45:03 +0200] rev 11535
core.certmanager: Check for complete filename
Prevents a false positive match on files with fullchain.pem as suffix
Kim Alvefur <zash@zash.se> [Wed, 05 May 2021 16:25:33 +0200] rev 11534
mod_tls: Fix order of debug messages and tls context creation
Originally added in 5b048ccd106f
Merged wrong in ca01c449357f
Matthew Wild <mwild1@gmail.com> [Fri, 30 Apr 2021 21:20:14 +0100] rev 11533
prosodyctl: check config: Add 'gc' to list of global options
Kim Alvefur <zash@zash.se> [Sun, 12 Jul 2020 23:04:14 +0200] rev 11532
configure: Make ICU the default library for IDNA and JID normalization
See #533
Kim Alvefur <zash@zash.se> [Sat, 24 Apr 2021 10:50:24 +0200] rev 11531
net.http.server: Split out method for sending only the header
Makes it easier to reuse, e.g. for SSE or websockets or other custom
responses.
Jonas Schäfer <jonas@wielicki.name> [Wed, 21 Apr 2021 17:11:58 +0200] rev 11530
s2s et al.: Add counters for connection state transitions
Jonas Schäfer <jonas@wielicki.name> [Sun, 18 Apr 2021 12:35:16 +0200] rev 11529
mod_s2s: Port to new OpenMetrics API
Jonas Schäfer <jonas@wielicki.name> [Sun, 18 Apr 2021 12:34:17 +0200] rev 11528
mod_c2s: Port to new OpenMetrics API
Jonas Schäfer <jonas@wielicki.name> [Sun, 18 Apr 2021 11:47:41 +0200] rev 11527
Statistics: Rewrite statistics backends to use OpenMetrics
The metric subsystem of Prosody has had some shortcomings from
the perspective of the current state-of-the-art in metric
observability.
The OpenMetrics standard [0] is a formalization of the data
model (and serialization format) of the well-known and
widely-used Prometheus [1] software stack.
The previous stats subsystem of Prosody did not map well to that
format (see e.g. [2] and [3]); the key reason is that it was
trying to do too much math on its own ([2]) while lacking
first-class support for "families" of metrics ([3]) and
structured metric metadata (despite the `extra` argument to
metrics, there was no standard way of representing common things
like "tags" or "labels").
Even though OpenMetrics has grown from the Prometheus world of
monitoring, it maps well to other popular monitoring stacks
such as:
- InfluxDB (labels can be mapped to tags and fields as necessary)
- Carbon/Graphite (labels can be attached to the metric name with
dot-separation)
- StatsD (see graphite when assuming that graphite is used as
backend, which is the default)
The util.statsd module has been ported to use the OpenMetrics
model as a proof of concept. An implementation which exposes
the util.statistics backend data as Prometheus metrics is
ready for publishing in prosody-modules (most likely as
mod_openmetrics_prometheus to avoid breaking existing 0.11
deployments).
At the same time, the previous measure()-based API had one major
advantage: It is really simple and easy to use without requiring
lots of knowledge about OpenMetrics or similar concepts. For that
reason as well as compatibility with existing code, it is preserved
and may even be extended in the future.
However, code relying on the `stats-updated` event as well as
`get_stats` from `statsmanager` will break because the data
model has changed completely; in case of `stats-updated`, the
code will simply not run (as the event was renamed in order
to avoid conflicts); the `get_stats` function has been removed
completely (so it will cause a traceback when it is attempted
to be used).
Note that the measure_*_event methods have been removed from
the module API. I was unable to find any uses or documentation
and thus deemed they should not be ported. Re-implementation is
possible when necessary.
[0]: https://openmetrics.io/
[1]: https://prometheus.io/
[2]: #959
[3]: #960
Kim Alvefur <zash@zash.se> [Sun, 25 Apr 2021 17:32:27 +0200] rev 11526
util.prosodyctl.shell: Fix for different location of unpack in Lua 5.1