Kim Alvefur <zash@zash.se> [Thu, 20 Jan 2022 10:51:46 +0100] rev 12206
util.xml: Deduplicate handlers for restricted XML
Makes the code more like util.xmppstream, allowing easier comparisons if
we ever need to apply fixes in the future.
Kim Alvefur <zash@zash.se> [Thu, 20 Jan 2022 09:57:20 +0100] rev 12205
util.xml: Break reference to help the GC (fix #1711)
LuaExpat uses a registry reference to track handlers, which makes
it so that an upvalue like this creates a reference loop that keeps the
parser and its handlers from being garbage collected. The same issue has
affected util.xmppstream in the past.
Code for checking:
local xml_parse = require"util.xml".parse;
for i = 1, 10000 do xml_parse("<root/>") end
collectgarbage(); collectgarbage();
print(collectgarbage("count"), "KiB");
A future release of LuaExpat may fix the underlying issue there.
Kim Alvefur <zash@zash.se> [Wed, 19 Jan 2022 10:28:09 +0100] rev 12204
util.prosodyctl.cert: Check success of copy operations, warn on fail
Debugging a case where certs are not imported correctly but prosodyctl
still reports success. Hoping this will shed some light on it.
Kim Alvefur <zash@zash.se> [Wed, 19 Jan 2022 10:26:43 +0100] rev 12203
util.prosodyctl.cert: Pass variables via formatting instead of concatenation
Prevents potential weirdness in case there's any %s or such in a host,
file or directory name, since show_warning() is printf().
Kim Alvefur <zash@zash.se> [Tue, 18 Jan 2022 15:43:17 +0100] rev 12202
tools/xep227toprosody: Remove obsolete tool in favor of storage driver
This tool hasn't been updated for recent XEP-0227 changes, hasn't seen
many changes at all since its introduction and I don't remember anyone
mentioning ever using it.
Using mod_storage_xmlarchive and the migrator or the 3rd party
mod_migrate tool should work better these days and should be the way
forward.
Kim Alvefur <zash@zash.se> [Tue, 18 Jan 2022 11:52:35 +0100] rev 12201
core.certmanager: Use 'tls_profile' instead of 'tls_preset' to match documentation
Confusion!
Thanks Martin
Kim Alvefur <zash@zash.se> [Tue, 18 Jan 2022 08:04:16 +0100] rev 12200
core.certmanager: Apply TLS preset before global settings (thanks Menel)
Allows overriding settings via the global 'ssl' settings as before.
This order was probably accidental. That said, 'ssl' is a giant footgun
we will want to discourage use of.
Matthew Wild <mwild1@gmail.com> [Mon, 17 Jan 2022 14:18:27 +0000] rev 12199
mod_storage_xep0227: Fix luacheck warning
Matthew Wild <mwild1@gmail.com> [Mon, 17 Jan 2022 14:12:45 +0000] rev 12198
mod_storage_xep0227: Fix traceback during iteration of driver stores
:include(other_set), :add(item)
Matthew Wild <mwild1@gmail.com> [Mon, 17 Jan 2022 14:11:45 +0000] rev 12197
mod_storage_xep0227: Fix file export (missing parameter) from refactor in 270047afa6af