util.promise: Remove some redundant checks, add tests confirming redundancy
This lines don't appear to do anything useful, and all tests pass when they
are removed. Discovered via mutation testing.
I added extra tests to exercise this code, because I wasn't certain that there
were no side-effects caused by removal. Everything appears to be fine, thanks
to the "pending" check at the start of promise_settle().
rules:
- id: log-variable-fmtstring
patterns:
- pattern: log("...", $A)
- pattern-not: log("...", "...")
message: Variable passed as format string to logging
languages: [lua]
severity: ERROR
- id: module-log-variable-fmtstring
patterns:
- pattern: module:log("...", $A)
- pattern-not: module:log("...", "...")
message: Variable passed as format string to logging
languages: [lua]
severity: ERROR
- id: module-getopt-string-default
patterns:
- pattern: module:get_option_string("...", $A)
- pattern-not: module:get_option_string("...", "...")
- pattern-not: module:get_option_string("...", host)
- pattern-not: module:get_option_string("...", module.host)
message: Non-string default from :get_option_string
severity: ERROR
languages: [lua]
- id: stanza-empty-text-constructor
patterns:
- pattern: $A:text()
message: Use :get_text() to read text, or pass a value here to add text
severity: WARNING
languages: [lua]