spec/util_multitable_spec.lua
author Jonas Schäfer <jonas@wielicki.name>
Mon, 10 Jan 2022 18:23:54 +0100
branch0.11
changeset 12185 783056b4e448
parent 8239 4878e4159e12
permissions -rw-r--r--
util.xml: Do not allow doctypes, comments or processing instructions Yes. This is as bad as it sounds. CVE pending. In Prosody itself, this only affects mod_websocket, which uses util.xml to parse the <open/> frame, thus allowing unauthenticated remote DoS using Billion Laughs. However, third-party modules using util.xml may also be affected by this. This commit installs handlers which disallow the use of doctype declarations and processing instructions without any escape hatch. It, by default, also introduces such a handler for comments, however, there is a way to enable comments nontheless. This is because util.xml is used to parse human-facing data, where comments are generally a desirable feature, and also because comments are generally harmless.


local multitable = require "util.multitable";

describe("util.multitable", function()
	describe("#new()", function()
		it("should create a multitable", function()
			local mt = multitable.new();
			assert.is_table(mt, "Multitable is a table");
			assert.is_function(mt.add, "Multitable has method add");
			assert.is_function(mt.get, "Multitable has method get");
			assert.is_function(mt.remove, "Multitable has method remove");
		end);
	end);

	describe("#get()", function()
		it("should allow getting correctly", function()
			local function has_items(list, ...)
				local should_have = {};
				if select('#', ...) > 0 then
					assert.is_table(list, "has_items: list is table", 3);
				else
					assert.is.falsy(list and #list > 0, "No items, and no list");
					return true, "has-all";
				end
				for n=1,select('#', ...) do should_have[select(n, ...)] = true; end
				for _, item in ipairs(list) do
					if not should_have[item] then return false, "too-many"; end
					should_have[item] = nil;
				end
				if next(should_have) then
					return false, "not-enough";
				end
				return true, "has-all";
			end
			local function assert_has_all(message, list, ...)
				return assert.are.equal(select(2, has_items(list, ...)), "has-all", message or "List has all expected items, and no more", 2);
			end

			local mt = multitable.new();

			local trigger1, trigger2, trigger3 = {}, {}, {};
			local item1, item2, item3 = {}, {}, {};

			assert_has_all("Has no items with trigger1", mt:get(trigger1));


			mt:add(1, 2, 3, item1);

			assert_has_all("Has item1 for 1, 2, 3", mt:get(1, 2, 3), item1);
		end);
	end);

	-- Doesn't support nil
	--[[	mt:add(nil, item1);
		mt:add(nil, item2);
		mt:add(nil, item3);

		assert_has_all("Has all items with (nil)", mt:get(nil), item1, item2, item3);
	]]
end);