util.xml: Do not allow doctypes, comments or processing instructions
Yes. This is as bad as it sounds. CVE pending.
In Prosody itself, this only affects mod_websocket, which uses util.xml
to parse the <open/> frame, thus allowing unauthenticated remote DoS
using Billion Laughs. However, third-party modules using util.xml may
also be affected by this.
This commit installs handlers which disallow the use of doctype
declarations and processing instructions without any escape hatch. It,
by default, also introduces such a handler for comments, however, there
is a way to enable comments nontheless.
This is because util.xml is used to parse human-facing data, where
comments are generally a desirable feature, and also because comments
are generally harmless.
# Pubsub: Create and delete
[Client] Romeo
jid: admin@localhost
password: password
// admin@localhost is assumed to have node creation privileges
---------
Romeo connects
Romeo sends:
<iq type="set" to="pubsub.localhost" id='create1'>
<pubsub xmlns="http://jabber.org/protocol/pubsub">
<create node="princely_musings"/>
</pubsub>
</iq>
Romeo receives:
<iq type="result" id='create1'/>
Romeo sends:
<iq type="set" to="pubsub.localhost" id='create2'>
<pubsub xmlns="http://jabber.org/protocol/pubsub">
<create node="princely_musings"/>
</pubsub>
</iq>
Romeo receives:
<iq type="error" id='create2'>
<error type="cancel">
<conflict xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
</error>
</iq>
Romeo sends:
<iq type="set" to="pubsub.localhost" id='delete1'>
<pubsub xmlns="http://jabber.org/protocol/pubsub#owner">
<delete node="princely_musings"/>
</pubsub>
</iq>
Romeo receives:
<iq type="result" id='delete1'/>
Romeo sends:
<iq type="set" to="pubsub.localhost" id='delete2'>
<pubsub xmlns="http://jabber.org/protocol/pubsub#owner">
<delete node="princely_musings"/>
</pubsub>
</iq>
Romeo receives:
<iq type="error" id='delete2'>
<error type="cancel">
<item-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
</error>
</iq>
Romeo disconnects
// vim: syntax=xml: