mod_websocket: Fire pre-session-close event (fixes #1800)
This event was added in a7c183bb4e64 and is required to make mod_smacks know
that a session was intentionally closed and shouldn't be hibernated (see
fcea4d9e7502).
Because this was missing from mod_websocket's session.close(), mod_smacks
would always attempt to hibernate websocket sessions even if they closed
cleanly.
That mod_websocket has its own copy of session.close() is something to fix
another day (probably not in the stable branch). So for now this commit makes
the minimal change to get things working again.
Thanks to Damian and the Jitsi team for reporting.
local xml = require "util.xml";
describe("util.xml", function()
describe("#parse()", function()
it("should work", function()
local x =
[[<x xmlns:a="b">
<y xmlns:a="c"> <!-- this overwrites 'a' -->
<a:z/>
</y>
<a:z/> <!-- prefix 'a' is nil here, but should be 'b' -->
</x>
]]
local stanza = xml.parse(x, {allow_comments = true});
assert.are.equal(stanza.tags[2].attr.xmlns, "b");
assert.are.equal(stanza.tags[2].namespaces["a"], "b");
end);
it("should reject doctypes", function()
local x = "<!DOCTYPE foo []><foo/>";
local ok = xml.parse(x);
assert.falsy(ok);
end);
it("should reject comments by default", function()
local x = "<foo><!-- foo --></foo>";
local ok = xml.parse(x);
assert.falsy(ok);
end);
it("should allow comments if asked nicely", function()
local x = "<foo><!-- foo --></foo>";
local stanza = xml.parse(x, {allow_comments = true});
assert.are.equal(stanza.name, "foo");
assert.are.equal(#stanza, 0);
end);
it("should reject processing instructions", function()
local x = "<foo><?php die(); ?></foo>";
local ok = xml.parse(x);
assert.falsy(ok);
end);
it("should allow processing instructions if asked nicely", function()
local x = "<?xml-stylesheet href='make-fancy.xsl'?><foo/>";
local stanza = xml.parse(x, {allow_processing_instructions = true});
assert.truthy(stanza);
assert.are.equal(stanza.name, "foo");
end);
it("should allow an xml declaration", function()
local x = "<?xml version='1.0'?><foo/>";
local stanza = xml.parse(x);
assert.truthy(stanza);
assert.are.equal(stanza.name, "foo");
end);
end);
end);