mod_websocket: Fire pre-session-close event (fixes #1800)
This event was added in a7c183bb4e64 and is required to make mod_smacks know
that a session was intentionally closed and shouldn't be hibernated (see
fcea4d9e7502).
Because this was missing from mod_websocket's session.close(), mod_smacks
would always attempt to hibernate websocket sessions even if they closed
cleanly.
That mod_websocket has its own copy of session.close() is something to fix
another day (probably not in the stable branch). So for now this commit makes
the minimal change to get things working again.
Thanks to Damian and the Jitsi team for reporting.
# MUC: Allow members to fetch the affiliation lists in open non-anonymous rooms
[Client] Romeo
jid: 4e2pm7er@localhost
password: password
[Client] Juliet
jid: qnjm5253@localhost
password: password
[Client] Random
jid: iqizbcus@localhost
password: password
-----
Romeo connects
Juliet connects
Random connects
# Romeo joins and creates the MUC
Romeo sends:
<presence to="mcgczevx@conference.localhost/Romeo">
<x xmlns="http://jabber.org/protocol/muc"/>
</presence>
Romeo receives:
<presence from="mcgczevx@conference.localhost/Romeo">
<x xmlns="http://jabber.org/protocol/muc#user" scansion:strict="false">
<item affiliation="owner" jid="${Romeo's full JID}" role="moderator"/>
<status code="110"/>
<status code="201"/>
</x>
</presence>
Romeo receives:
<message from="mcgczevx@conference.localhost" type="groupchat">
<subject/>
</message>
# and configures it for private chat
Romeo sends:
<iq type="set" id="17fb8e7e-c75e-447c-b86f-3f1df8f507c4" to="mcgczevx@conference.localhost">
<query xmlns="http://jabber.org/protocol/muc#owner">
<x type="submit" xmlns="jabber:x:data">
<field var="FORM_TYPE">
<value>http://jabber.org/protocol/muc#roomconfig</value>
</field>
<field var="muc#roomconfig_membersonly">
<value>1</value>
</field>
<field var="muc#roomconfig_whois">
<value>anyone</value>
</field>
</x>
</query>
</iq>
Romeo receives:
<iq from="mcgczevx@conference.localhost" id="17fb8e7e-c75e-447c-b86f-3f1df8f507c4" type="result"/>
Romeo receives:
<message from="mcgczevx@conference.localhost" type="groupchat">
<x xmlns="http://jabber.org/protocol/muc#user" scansion:strict="false">
<status code="104"/>
<status code="172"/>
</x>
</message>
# Juliet is made a member
Romeo sends:
<iq type="set" id="32d81574-e1dc-4221-b36d-4c44debb7c19" to="mcgczevx@conference.localhost">
<query xmlns="http://jabber.org/protocol/muc#admin">
<item affiliation="member" jid="${Juliet's JID}"/>
</query>
</iq>
# Juliet can read affiliations
Juliet sends:
<iq type="get" id="32d81574-e1dc-4221-b36d-4c44debb7c19" to="mcgczevx@conference.localhost">
<query xmlns="http://jabber.org/protocol/muc#admin">
<item affiliation="owner"/>
</query>
</iq>
Juliet receives:
<iq from="mcgczevx@conference.localhost" id="32d81574-e1dc-4221-b36d-4c44debb7c19" type="result">
<query xmlns="http://jabber.org/protocol/muc#admin">
<item affiliation="owner" jid="${Romeo's JID}"/>
</query>
</iq>
Juliet sends:
<iq type="get" id="05e3fe30-976f-4919-8221-ca1ac333eb9b" to="mcgczevx@conference.localhost">
<query xmlns="http://jabber.org/protocol/muc#admin">
<item affiliation="member"/>
</query>
</iq>
Juliet receives:
<iq from="mcgczevx@conference.localhost" id="05e3fe30-976f-4919-8221-ca1ac333eb9b" type="result">
<query xmlns="http://jabber.org/protocol/muc#admin">
<item affiliation="member" jid="${Juliet's JID}"/>
</query>
</iq>
# Others can't read affiliations
Random sends:
<iq type="get" id="df1195e1-7ec8-4102-8561-3e3a1d942adf" to="mcgczevx@conference.localhost">
<query xmlns="http://jabber.org/protocol/muc#admin">
<item affiliation="owner"/>
</query>
</iq>
Random receives:
<iq from="mcgczevx@conference.localhost" id="df1195e1-7ec8-4102-8561-3e3a1d942adf" type="error"/>
Juliet disconnects
Romeo disconnects
Random disconnects
# recording ended on 2021-07-23T12:09:48Z