mod_websocket: Fire pre-session-close event (fixes #1800)
This event was added in a7c183bb4e64 and is required to make mod_smacks know
that a session was intentionally closed and shouldn't be hibernated (see
fcea4d9e7502).
Because this was missing from mod_websocket's session.close(), mod_smacks
would always attempt to hibernate websocket sessions even if they closed
cleanly.
That mod_websocket has its own copy of session.close() is something to fix
another day (probably not in the stable branch). So for now this commit makes
the minimal change to get things working again.
Thanks to Damian and the Jitsi team for reporting.
# XEP-0215: External Service Discovery
[Client] Romeo
password: password
jid: user@localhost/mFquWxSr
-----
Romeo connects
Romeo sends:
<iq type='get' xml:lang='sv' id='lx2' to='localhost'>
<services xmlns='urn:xmpp:extdisco:2'/>
</iq>
Romeo receives:
<iq type='result' id='lx2' from='localhost'>
<services xmlns='urn:xmpp:extdisco:2'>
<service host='default.example' transport='udp' port='9876' type='stun'/>
<service port='9876' type='turn' restricted='1' password='yHYYBDN7M3mdlug0LTdJbW0GvvQ=' transport='udp' host='default.example' username='1219525744'/>
<service port='9876' type='turn' restricted='1' password='1Uc6QfrDhIlbK97rGCUQ/cUICxs=' transport='udp' host='default.example' username='1219525744'/>
<service port='2121' type='ftp' restricted='1' password='password' transport='tcp' host='default.example' username='john'/>
<service port='21' type='ftp' restricted='1' password='password' transport='tcp' host='ftp.example.com' username='john'/>
</services>
</iq>
Romeo sends:
<iq type='get' xml:lang='sv' id='lx3' to='localhost'>
<services xmlns='urn:xmpp:extdisco:2' type='ftp'/>
</iq>
Romeo receives:
<iq type='result' id='lx3' from='localhost'>
<services xmlns='urn:xmpp:extdisco:2'>
<service port='2121' type='ftp' restricted='1' password='password' transport='tcp' host='default.example' username='john'/>
<service port='21' type='ftp' restricted='1' password='password' transport='tcp' host='ftp.example.com' username='john'/>
</services>
</iq>
Romeo sends:
<iq type='get' xml:lang='sv' id='lx4' to='localhost'>
<credentials xmlns='urn:xmpp:extdisco:2'>
<service host='default.example' type='turn'/>
</credentials>
</iq>
Romeo receives:
<iq type='result' id='lx4' from='localhost'>
<credentials xmlns='urn:xmpp:extdisco:2'>
<service port='9876' type='turn' restricted='1' password='yHYYBDN7M3mdlug0LTdJbW0GvvQ=' transport='udp' host='default.example' username='1219525744'/>
<service port='9876' type='turn' restricted='1' password='1Uc6QfrDhIlbK97rGCUQ/cUICxs=' transport='udp' host='default.example' username='1219525744'/>
</credentials>
</iq>
Romeo sends:
<iq type='get' xml:lang='sv' id='lx5' to='localhost'>
<credentials xmlns='urn:xmpp:extdisco:2'>
<service host='default.example' />
</credentials>
</iq>
Romeo receives:
<iq type='error' id='lx5' from='localhost'>
<error type='modify'>
<bad-request xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
</error>
</iq>
Romeo disconnects
# recording ended on 2020-07-18T16:47:57Z