util/xml.lua
changeset 12274 c78639ee6ccb
parent 12207 320de3e4b579
child 12979 d10957394a3c
--- a/util/xml.lua	Fri Feb 04 20:11:18 2022 +0100
+++ b/util/xml.lua	Fri Feb 04 20:47:39 2022 +0100
@@ -72,11 +72,14 @@
 			end
 		end
 		handler.StartDoctypeDecl = restricted_handler;
-		handler.ProcessingInstruction = restricted_handler;
 		if not options or not options.allow_comments then
 			-- NOTE: comments are generally harmless and can be useful when parsing configuration files or other data, even user-provided data
 			handler.Comment = restricted_handler;
 		end
+		if not options or not options.allow_processing_instructions then
+			-- Processing instructions should generally be safe to just ignore
+			handler.ProcessingInstruction = restricted_handler;
+		end
 		local parser = lxp.new(handler, ns_separator);
 		local ok, err, line, col = parser:parse(xml);
 		if ok then ok, err, line, col = parser:parse(); end