util.promise: Remove some redundant checks, add tests confirming redundancy This lines don't appear to do anything useful, and all tests pass when they are removed. Discovered via mutation testing. I added extra tests to exercise this code, because I wasn't certain that there were no side-effects caused by removal. Everything appears to be fine, thanks to the "pending" check at the start of promise_settle().

     1

local xpcall = xpcall;

     2

     3

if select(2, xpcall(function (x) return x end, function () end,  "test")) ~= "test" then

     4

	xpcall = require"util.compat".xpcall;

     5

end

     6

     7

return {

     8

	xpcall = xpcall;

     9

};