Mercurial Mercurial > prosody > prosody / annotate
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
.semgrep.yml
author Kim Alvefur <zash@zash.se>
Sat, 02 Mar 2024 13:23:24 +0100
changeset 13456 69faf3552d52
parent 12721 898e99f49d80
permissions -rw-r--r--
mod_posix: Move POSIX signal handling into util.startup to avoid race When libunbound is initialized, it spawns a thread to work in. In case a module initializes libunbound, e.g. by triggering a s2s connection, Prosody would not handle signals, instead immediately quit on e.g. the reload (SIGHUP) signal. Likely because the libunbound thread would not have inherited the signal mask from the main Prosody thread. Thanks Menel, riau and franck-x for reporting and help narrowing down
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
11293
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     1
 
rules:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     2
 
- id: log-variable-fmtstring
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     3
 
  patterns:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     4
 
    - pattern: log("...", $A)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     5
 
    - pattern-not: log("...", "...")
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     6
 
  message: Variable passed as format string to logging
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     7
 
  languages: [lua]
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     8
 
  severity: ERROR
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     9
 
- id: module-log-variable-fmtstring
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    10
 
  patterns:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    11
 
    - pattern: module:log("...", $A)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    12
 
    - pattern-not: module:log("...", "...")
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    13
 
  message: Variable passed as format string to logging
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    14
 
  languages: [lua]
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    15
 
  severity: ERROR
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    16
 
- id: module-getopt-string-default
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    17
 
  patterns:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    18
 
    - pattern: module:get_option_string("...", $A)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    19
 
    - pattern-not: module:get_option_string("...", "...")
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    20
 
    - pattern-not: module:get_option_string("...", host)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    21
 
    - pattern-not: module:get_option_string("...", module.host)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    22
 
  message: Non-string default from :get_option_string
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    23
 
  severity: ERROR
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    24
 
  languages: [lua]
12721
898e99f49d80 semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents: 11293
diff changeset 
    25
 
- id: stanza-empty-text-constructor
898e99f49d80 semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents: 11293
diff changeset 
    26
 
  patterns:
898e99f49d80 semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents: 11293
diff changeset 
    27
 
    - pattern: $A:text()
898e99f49d80 semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents: 11293
diff changeset 
    28
 
  message: Use :get_text() to read text, or pass a value here to add text
898e99f49d80 semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents: 11293
diff changeset 
    29
 
  severity: WARNING
898e99f49d80 semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents: 11293
diff changeset 
    30
 
  languages: [lua]
prosody