util.xml: Do not allow doctypes, comments or processing instructions Yes. This is as bad as it sounds. CVE pending. In Prosody itself, this only affects mod_websocket, which uses util.xml to parse the <open/> frame, thus allowing unauthenticated remote DoS using Billion Laughs. However, third-party modules using util.xml may also be affected by this. This commit installs handlers which disallow the use of doctype declarations and processing instructions without any escape hatch. It, by default, also introduces such a handler for comments, however, there is a way to enable comments nontheless. This is because util.xml is used to parse human-facing data, where comments are generally a desirable feature, and also because comments are generally harmless.

     1

-- This tests the format, not the randomness

     2

     3

local uuid = require "util.uuid";

     4

     5

describe("util.uuid", function()

     6

	describe("#generate()", function()

     7

		it("should work follow the UUID pattern", function()

     8

			-- https://tools.ietf.org/html/rfc4122#section-4.4

     9

    10

			local pattern = "^" .. table.concat({

    11

				string.rep("%x", 8),

    12

				string.rep("%x", 4),

    13

				"4" .. -- version

    14

				string.rep("%x", 3),

    15

				"[89ab]" .. -- reserved bits of 1 and 0

    16

				string.rep("%x", 3),

    17

				string.rep("%x", 12),

    18

			}, "%-") .. "$";

    19

    20

			for _ = 1, 100 do

    21

				assert.is_string(uuid.generate():match(pattern));

    22

			end

    23

		end);

    24

	end);

    25

end);