util.xml: Do not allow doctypes, comments or processing instructions Yes. This is as bad as it sounds. CVE pending. In Prosody itself, this only affects mod_websocket, which uses util.xml to parse the <open/> frame, thus allowing unauthenticated remote DoS using Billion Laughs. However, third-party modules using util.xml may also be affected by this. This commit installs handlers which disallow the use of doctype declarations and processing instructions without any escape hatch. It, by default, also introduces such a handler for comments, however, there is a way to enable comments nontheless. This is because util.xml is used to parse human-facing data, where comments are generally a desirable feature, and also because comments are generally harmless.

     1

local httpstreams = { [[

     2

GET / HTTP/1.1

     3

Host: example.com

     4

     5

]], [[

     6

HTTP/1.1 200 OK

     7

Content-Length: 0

     8

     9

]], [[

    10

HTTP/1.1 200 OK

    11

Content-Length: 7

    12

    13

Hello

    14

HTTP/1.1 200 OK

    15

Transfer-Encoding: chunked

    16

    17

1

    18

H

    19

1

    20

e

    21

2

    22

ll

    23

1

    24

o

    25

0

    26

    27

    28

]]

    29

}

    30

    31

    32

local http_parser = require "net.http.parser";

    33

    34

describe("net.http.parser", function()

    35

	describe("#new()", function()

    36

		it("should work", function()

    37

			for _, stream in ipairs(httpstreams) do

    38

				local success;

    39

				local function success_cb(packet)

    40

					success = true;

    41

				end

    42

				stream = stream:gsub("\n", "\r\n");

    43

				local parser = http_parser.new(success_cb, error, stream:sub(1,4) == "HTTP" and "client" or "server")

    44

				for chunk in stream:gmatch("..?.?") do

    45

					parser:feed(chunk);

    46

				end

    47

    48

				assert.is_true(success);

    49

			end

    50

		end);

    51

	end);

    52

end);