mod_pubsub_feeds: Add new interval setting in seconds (old still works) To match most other such settings.

mod_pubsub_feeds: Disable WebSub (formerly PubSubHubbub) by default I have seen no recent evidence of this being used or supported by anything anywhere anymore.

mod_http_oauth2: Always show list of requested scopes Upon further reflection, these are probably too important to hide behind a <details> thing.

mod_muc_limits: Add a limit on number of bytes in a message body

mod_muc_limits: Add a limit on number of lines per message More vertical space -> more cost

mod_muc_limits: Normalise README markdown syntax (thanks pandoc)

mod_muc_limits: Raise cost for multi-line messages

Back out 22784f001b7f: Documentation change did not match code (thanks bronko)

mod_http_oauth2: Rearrange description of redirect URIs requirements So that they're in one place only instead of sorta twice.

mod_http_oauth2: Add a more complete client registration example More fields from RFC 7591. We should probably mention and recommend more of them, especially the ones that are recorded in grants.

mod_http_oauth2: Strip JWKS metadata since we do not understand that Maybe one day whatever this is will be understood, but not this day!

mod_http_oauth2: Strip unknown client metadata Per RFC 7591 > The authorization server MUST ignore any client metadata sent by the > client that it does not understand (for instance, by silently removing > unknown metadata from the client's registration record during > processing). This was previously done but unintentionally removed in 90449babaa48

mod_rest: Map the archive-id attribute in MAM result items I was wondering why this wasn't in the JSON output

mod_rest: Include full_jid property on origin Fixes permission check in disco#info query to your own account, where the 'to' would have been stripped since it equals the account JID, leaving mod_disco passing nil, which triggers an error in module:may()

mod_oidc_userinfo_vcard4: Remove unused import

mod_oidc_userinfo_vcard4: Fix typo

mod_http_oauth2: Make allowed locales configurable Explicit > Implicit Instead of allowing anything after #, allow only the explicitly configured locales to be used. Default to empty list because using these is not supported yet. This potentially limits the size of the client_id, which is already quite large. Nothing prevents clients from registering a whole client_id per locale, which would not require translation support on this side.

mod_http_oauth2: Improve error messages for URI properties Since there are separate validation checks for URI properties, including that they should use https, with better and more specific error reporting. Reverts 'luaPattern' to 'pattern' which is not currently supported by util.jsonschema, but allows anything that retrieves the schema over http to validate against it, should they wish to do so.

mod_rest: Describe the error 'by' property in OpenAPI spec

mod_rest: List all error conditions in OpenAPI spec These are not handled by datamanager but by util.stanza and util.error, so they are not represented in the JSON schema file.

mod_http_oauth2: Make note about handling repeated RFC 6749 states > If an authorization code is used more than once, the authorization > server MUST deny the request and SHOULD revoke (when possible) all > tokens previously issued based on that authorization code. We should follow the SHOULD. The MUST is already covered by removing the code state from the cache.

mod_http_oauth2: Add TODO about disabling password grant Per recommendation in draft-ietf-oauth-security-topics-23 it should at the very least be disabled by default. However since this is used by the Snikket web portal some care needs to be taken not to break this, unless it's already broken by other changes to this module.

mod_http_oauth2: Disable CORS for authorization endpoint Per recommendation in draft-ietf-oauth-security-topics-23 Hopefully it is enough to return an error status, since mod_http will add CORS headers from a handler with higher priority, even for OPTIONS.

mod_http_oauth2: Make CSP configurable E.g. to enable forbidding all scripts if you don't use any scripts, or allow scripts from your separate static content domain, etc.

mod_http_oauth2: Link to RFC 7628 in README Links are good.

mod_http_oauth2: Use code spans for some config options in README To make them more recognisable as code things.

mod_http_oauth2: Remove underscore prefix LuaCheck considers this to mean that a variable it unused, but this one is not.

mod_cloud_notify_extensions: Fix Markdown syntax of Compatibility table

mod_firewall: Add console commands to mark/unmark users

mod_firewall: Load marks from storage on demand rather than at login This ensures people who don't use marks, or use them infrequently, don't pay a perf cost on every resource bind.

mod_firewall: Log warning when attempting to mark/unmark remote users

mod_firewall: enable marks by default

mod_firewall: Improve error when mark name contains invalid characters

mod_firewall: marks: Fix marking a user with no previous marks

mod_firewall: Update user marks to store instantly via map store The original approach was to keep marks in memory only, and persist them at shutdown. That saves I/O, at the cost of potentially losing marks on an unclean shutdown. This change persists marks instantly, which may have some performance overhead but should be more "correct". It also splits the marking/unmarking into an event which may be watched or even fired by other modules.

mod_firewall: Split some long lines [luacheck]

mod_firewall: Fix inverted logic of 'FROM FULL JID?'

mod_firewall: spam-blocking.pfw: Remove requirement for invites to have no body Some clients (e.g. Gajim) send a body, which I guess makes sense. The bare JID sender check should already make it hard to bypass this (i.e. a normal client putting muc#user into a normal chat message shouldn't bypass the usual message filters).

mod_firewall: scripts: spam-blocklists: Check sender and inviter of MUC invitations against blocklist

mod_firewall: scripts: spam-blocking.pfw: Add special handling for MUC invites

mod_firewall: Add 'FROM FULL JID?' condition

mod_firewall: README: Add some emphasis on the exact behaviour of TO FULL JID

mod_rest: Merge some common properties between openapi and schema

mod_rest: Apply normalization to openapi spec Using https://github.com/mikefarah/yq v4.34.1 --prettyPrint

mod_http_oauth2: Simplify template using if-falsy operator Relies on Prosody rev af1e3b7d9ea3 which added the {var~if-falsy}, released in 0.12. Since this module requires trunk this is fine.

mod_http_dir_listing2: Fix wrong name for resource directory

mod_http_dir_listing2: Include html resources with plugin installer

mod_http_dir_listing: Strip path to using plugin installer

mod_firewall: Include scripts with plugin installer (thanks gooya)

mod_http_oauth2: Add some words about supported flows and defaults

mod_http_oauth2/README: Expand summary to include OAuth 2.0 role This module implements the Authorization Server parts of OAuth 2.0, so having the summary say that seems sensible.

mod_http_oauth2: Return Authentication Time per OpenID Core Section 2 Mandatory To Implement, either MUST include or OPTIONAL depending on things we don't look at, so might as well include it all the time. Since we do not persist authentication state with cookies or such, the authentication time will always be some point between the user being sent to the authorization endpoint and the time they are sent back to the client application.

mod_http_oauth2: Validate the OpenID 'prompt' parameter Without support for affecting the login and consent procedure, it seems sensible to inform the client that they can't change anything with this parameter.

mod_http_oauth2: Apply text color to OOB input field Was using the browser default color

mod_client_management: Include client software version number in listing Should you ever wish to revoke a client by version number, e.g. for security reasons affecting certain versions, then it would be good to at the very least see which version is used. Also includes the OAuth2 software ID, an optional unique identifier that should be the same for all installations of a particular software.

mod_http_oauth2: Present OOB code in an input field for easier selection Should also avoid stray whitespace making it into the selection.

mod_http_oauth2: Revert strict form check to allow consent of multiple scopes Untested commit breaks everything, news at 11

mod_http_oauth2: Reject duplicate form-urlencoded parameters Per RFC 6749 section 3.1 > Request and response parameters MUST NOT be included more than once. Thanks to OAuch for pointing out Also cleans up some of the icky behavior of formdecode(), like returning a string if no '=' is included.

mod_http_oauth2: Bind refresh tokens to client Prevent one OAuth client from using the refresh tokens issued to another client as required by RFC 6819 section 5.2.2.2 See also draft-ietf-oauth-security-topics-22 section 2.2.2 Thanks to OAuch for pointing out this issue

mod_http_oauth2: Record hash of client_id to allow future verification RFC 6819 section 5.2.2.2 states that refresh tokens MUST be bound to the client. In order to do that, we must record something that can definitely tie the client to the grant. Since the full client_id is so large (why we have this client_subset function), a hash is stored instead.