# HG changeset patch # User Mikael Hallendal # Date 1224548469 -7200 # Node ID c452438237561962a6439a2e00d1591e3198487a # Parent c917a1900d5ca801d074ee67eeb5b1b4f0ef973c Added some TODO items and minor style fixes diff -r c917a1900d5c -r c45243823756 loudmouth/lm-connection.c --- a/loudmouth/lm-connection.c Mon Oct 20 17:48:04 2008 +0200 +++ b/loudmouth/lm-connection.c Tue Oct 21 02:21:09 2008 +0200 @@ -105,6 +105,8 @@ struct _LmConnection { /* Parameters */ GMainContext *context; + + /* TODO: Clean up this and make some parameter object for server, jid, effective jid etc */ gchar *server; gchar *jid; gchar *effective_jid; @@ -145,6 +147,7 @@ LmConnectionState state; + /* TODO: Move the rate to use the one in LmFeaturePing instead of keeping the two in sync */ guint keep_alive_rate; LmFeaturePing *feature_ping; @@ -1504,6 +1507,8 @@ connection->effective_jid = g_strdup_printf ("%s/%s", connection->jid, connection->resource); + /* TODO: Break out Credentials (or use the already existing AuthReqData struct for * + * Username/Password and Resource */ if (connection->use_sasl) { lm_sasl_authenticate (connection->sasl, username, password, diff -r c917a1900d5c -r c45243823756 loudmouth/lm-utils.c --- a/loudmouth/lm-utils.c Mon Oct 20 17:48:04 2008 +0200 +++ b/loudmouth/lm-utils.c Tue Oct 21 02:21:09 2008 +0200 @@ -48,8 +48,8 @@ #include "lm-utils.h" LmCallback * -_lm_utils_new_callback (gpointer func, - gpointer user_data, +_lm_utils_new_callback (gpointer func, + gpointer user_data, GDestroyNotify notify) { LmCallback *cb;