Mercurial Mercurial > prosody > prosody / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
MUC: Don't default component admins to being room owners default tip
authorMatthew Wild <mwild1@gmail.com>
Tue, 18 Jun 2024 15:08:30 +0100
changeset 13500 3e6d5738ea09
parent 13499 47e1df2d0a37
MUC: Don't default component admins to being room owners This change has various technical and social benefits. If ownership of a MUC is really needed, it can be gained using the 'Set affiliation' ad-hoc command or prosodyctl shell. Example client incompatibility with the old behaviour: - https://github.com/monal-im/Monal/issues/1085
CHANGES file | annotate | diff | comparison | revisions
plugins/muc/mod_muc.lua file | annotate | diff | comparison | revisions 
--- a/CHANGES	Thu May 23 17:39:20 2024 +0100
+++ b/CHANGES	Tue Jun 18 15:08:30 2024 +0100
@@ -16,6 +16,10 @@
 
 ### MUC
 
+- Component admins are no longer room owners by default. This can be reverted
+  to the old behaviour with `component_admins_as_room_owners = true`, but this
+  has known incompatibilities with some clients. Instead, use the shell or
+  ad-hoc commands to gain ownership of rooms when necessary.
 - Permissions updates:
   - Room creation restricted to local users (of the parent host) by default
     - restrict_room_creation = true restricts to admins, false disables all restrictions
--- a/plugins/muc/mod_muc.lua	Thu May 23 17:39:20 2024 +0100
+++ b/plugins/muc/mod_muc.lua	Tue Jun 18 15:08:30 2024 +0100
@@ -125,7 +125,7 @@
 	":list-rooms";
 });
 
-if module:get_option_boolean("component_admins_as_room_owners", true) then
+if module:get_option_boolean("component_admins_as_room_owners", false) then
 	-- Monkey patch to make server admins room owners
 	local _get_affiliation = room_mt.get_affiliation;
 	function room_mt:get_affiliation(jid)
prosody