# HG changeset patch # User Matthew Wild # Date 1601447132 -3600 # Node ID d334f2bebe552a54e6caface56529d94eff0924c # Parent 6a608ecb347130911c30fa9621cb334411ca6e52# Parent 7d4c292f178e8e6fb1981c5851e1760d715de0b6 Merge 0.11->trunk diff -r 6a608ecb3471 -r d334f2bebe55 spec/util_indexedbheap_spec.lua --- a/spec/util_indexedbheap_spec.lua Tue Sep 29 15:30:48 2020 +0100 +++ b/spec/util_indexedbheap_spec.lua Wed Sep 30 07:25:32 2020 +0100 @@ -1,15 +1,33 @@ local ibh = require"util.indexedbheap"; + +local function verify_heap_property(priorities) + for k in ipairs(priorities) do + local parent = priorities[k]; + local childA = priorities[2*k]; + local childB = priorities[2*k+1]; + -- print("-", parent, childA, childB) + assert(childA == nil or childA > parent, "heap property violated"); + assert(childB == nil or childB > parent, "heap property violated"); + end +end + local h setup(function () h = ibh.create(); end) describe("util.indexedbheap", function () - pending("item can be moved from end to top", function () + it("item can be moved from end to top", function () + verify_heap_property(h); h:insert("a", 1); + verify_heap_property(h); h:insert("b", 2); + verify_heap_property(h); h:insert("c", 3); + verify_heap_property(h); local id = h:insert("*", 10); + verify_heap_property(h); h:reprioritize(id, 0); + verify_heap_property(h); assert.same({ 0, "*", id }, { h:pop() }); end) end); diff -r 6a608ecb3471 -r d334f2bebe55 util/indexedbheap.lua --- a/util/indexedbheap.lua Tue Sep 29 15:30:48 2020 +0100 +++ b/util/indexedbheap.lua Wed Sep 30 07:25:32 2020 +0100 @@ -23,7 +23,7 @@ local tmp_sync = sync[k]; while k ~= 1 do local parent = math_floor(k/2); - if tmp < self[parent] then break; end + if tmp >= self[parent] then break; end self[k] = self[parent]; sync[k] = sync[parent]; index[sync[k]] = k;