Matthew Wild <mwild1@gmail.com> [Tue, 16 Nov 2021 12:02:54 +0000] rev 11914
MUC: Set .previous_affiliation = "none" if nil, for consistency with .affiliation
It appears nothing currently uses this field in prosody or prosody-modules
Matthew Wild <mwild1@gmail.com> [Tue, 16 Nov 2021 11:54:32 +0000] rev 11913
MUC: Fix incorrect variable name (thanks luacheck)
Matthew Wild <mwild1@gmail.com> [Tue, 16 Nov 2021 11:52:36 +0000] rev 11912
MUC: Switch to event.allowed signaling to block event, matching muc-pre-set-role
...and fixing the logic bug that broke everything in the previous commit.
Matthew Wild <mwild1@gmail.com> [Tue, 16 Nov 2021 11:41:08 +0000] rev 11911
MUC: Add 'muc-pre-set-affiliation' event, allowing to block change or modify data
Matthew Wild <mwild1@gmail.com> [Mon, 15 Nov 2021 16:11:03 +0000] rev 11910
MUC: Add option to include form in registration query
This was originally not done based on my interpretation of XEP-0045. Today's
reading, however, revealed that it actually says the result
> SHOULD contain **at least** a <username/> element
(emphasis mine)
I take this to mean that including a form **is** allowed (and I think this is
sensible). Tigase already includes the form I believe.
I've gated the new behaviour behind a (default off) option, because it hasn't
been tested for compatibility with clients. My primary desire for it is in
Snikket, where the clients will be tested to ensure compatibility with this.
I don't anticipate that (m)any clients would break, so maybe after 0.12 we can
experiment with enabling it by default and eventually remove the option.
Kim Alvefur <zash@zash.se> [Mon, 15 Nov 2021 13:31:06 +0100] rev 11909
mod_admin_shell: Handle absence of connection in security column (thanks arcseconds)
I surmise this can happen in a disconnected/smacks hibernation state.
Kim Alvefur <zash@zash.se> [Sat, 13 Nov 2021 22:12:39 +0100] rev 11908
mod_pubsub: Fix traceback in disco of non-existent node (thanks Martin)
In this case `ret` is a table not containing the node, which makes
pubsub_error_reply() try to get an error template with that `ret` table
as index, which returns a `nil` then passed to table.unpack, which in
turn throws the error.
Kim Alvefur <zash@zash.se> [Sat, 13 Nov 2021 13:32:43 +0100] rev 11907
net.connect: Prefer last connection error over last resolver error
E.g. "connection refused" over one IP version instead of NoError for the
other IP version.
Kim Alvefur <zash@zash.se> [Fri, 12 Nov 2021 22:34:04 +0100] rev 11906
util.prosodyctl.shell: Bring back banner set from config!
I miss my custom ANSI-colored greeting!
Kim Alvefur <zash@zash.se> [Fri, 12 Nov 2021 16:52:55 +0100] rev 11905
net.connect: Propagate last error message from resolvers
Previously it would only say "unable to resolve server" for all DNS
problems. While "NoError in A lookup" might not make much sense to
users, it should help in debugging more than the previous generic error.
Friendlier errors will be future work.