Kim Alvefur <zash@zash.se> [Fri, 27 May 2022 14:45:35 +0200] rev 12530
mod_smacks: Bounce unhandled stanzas from local origin (fix #1759)
Sending stanzas with a remote session as origin when the stanzas have a
local JID in the from attribute trips validation in core.stanza_router,
leading to warnings:
> Received a stanza claiming to be from remote.example, over a stream authed for localhost.example
Using module:send() uses the local host as origin, which is fine here.
Kim Alvefur <zash@zash.se> [Fri, 27 May 2022 12:05:47 +0200] rev 12529
mod_smacks: Fix bounce of stanzas directed to full JID on unclean disconnect
Fixes #1758
Introduced in 1ea01660c79a
In e62025f949f9 to and from was inverted since it changed from acting on
a reply to acting on the original stanza (or a clone thereof)
Unsure of the purpose of this check, you don't usually send stanzas to
your own full JID. Perhaps guarding against routing loops?
The check was present in the original commit of mod_smacks,
prosody-modules rev 9a7671720dec
Kim Alvefur <zash@zash.se> [Thu, 26 May 2022 19:24:01 +0200] rev 12528
mod_smacks: Remove debug log references to timer (not used anymore)
Cuts down on noise as well
Kim Alvefur <zash@zash.se> [Thu, 26 May 2022 17:48:59 +0200] rev 12527
Merge 0.12->trunk
Kim Alvefur <zash@zash.se> [Thu, 26 May 2022 17:38:55 +0200] rev 12526
mod_smacks: Fix to use current method of counting acked stanzas
Fixes #1757
These places seem to have been left since e62025f949f9
The logic around expected_h in should_ack() misbehaved, always comparing
with 0 + unacked instead of acked + unacked.
Kim Alvefur <zash@zash.se> [Thu, 26 May 2022 13:46:10 +0200] rev 12525
Merge 0.12->trunk
Kim Alvefur <zash@zash.se> [Thu, 26 May 2022 13:03:58 +0200] rev 12524
util.prosodyctl.check: Remove now redundant unbound config tweak
This is now done in net.unbound itself
Turning it back on in the config may still cause the problem of entries
there masking the DNS values.
Kim Alvefur <zash@zash.se> [Sat, 21 May 2022 13:11:25 +0200] rev 12523
mod_smacks: Use session logging for remaining log messages
For consistency and easier correlation of session events.
Kim Alvefur <zash@zash.se> [Fri, 11 Feb 2022 16:09:42 +0100] rev 12522
mod_smacks: Factor out some convenience functions
Those lines are long and the risk of mistakes if another one needs to be
added seems high, but lower when factored out like this.
Kim Alvefur <zash@zash.se> [Tue, 17 May 2022 17:06:36 +0200] rev 12521
util.stanza: Document top level attributes in Teal definition
Tells you if you make a typo like "gropchat" or so