mod_websocket: Fire pre-session-close event (fixes #1800)
This event was added in a7c183bb4e64 and is required to make mod_smacks know
that a session was intentionally closed and shouldn't be hibernated (see
fcea4d9e7502).
Because this was missing from mod_websocket's session.close(), mod_smacks
would always attempt to hibernate websocket sessions even if they closed
cleanly.
That mod_websocket has its own copy of session.close() is something to fix
another day (probably not in the stable branch). So for now this commit makes
the minimal change to get things working again.
Thanks to Damian and the Jitsi team for reporting.
describe("parse", function()
local parse
setup(function() parse = require"util.argparse".parse; end);
it("works", function()
-- basic smoke test
local opts = parse({ "--help" });
assert.same({ help = true }, opts);
end);
it("returns if no args", function() assert.same({}, parse({})); end);
it("supports boolean flags", function()
local opts, err = parse({ "--foo"; "--no-bar" });
assert.falsy(err);
assert.same({ foo = true; bar = false }, opts);
end);
it("consumes input until the first argument", function()
local arg = { "--foo"; "bar"; "--baz" };
local opts, err = parse(arg);
assert.falsy(err);
assert.same({ foo = true, "bar", "--baz" }, opts);
assert.same({ "bar"; "--baz" }, arg);
end);
it("expands short options", function()
local opts, err = parse({ "--foo"; "-b" }, { short_params = { b = "bar" } });
assert.falsy(err);
assert.same({ foo = true; bar = true }, opts);
end);
it("supports value arguments", function()
local opts, err = parse({ "--foo"; "bar"; "--baz=moo" }, { value_params = { foo = true; bar = true } });
assert.falsy(err);
assert.same({ foo = "bar"; baz = "moo" }, opts);
end);
it("demands values for value params", function()
local opts, err, where = parse({ "--foo" }, { value_params = { foo = true } });
assert.falsy(opts);
assert.equal("missing-value", err);
assert.equal("--foo", where);
end);
it("reports where the problem is", function()
local opts, err, where = parse({ "-h" });
assert.falsy(opts);
assert.equal("param-not-found", err);
assert.equal("-h", where, "returned where");
end);
end);