util.xml: Do not allow doctypes, comments or processing instructions Yes. This is as bad as it sounds. CVE pending. In Prosody itself, this only affects mod_websocket, which uses util.xml to parse the <open/> frame, thus allowing unauthenticated remote DoS using Billion Laughs. However, third-party modules using util.xml may also be affected by this. This commit installs handlers which disallow the use of doctype declarations and processing instructions without any escape hatch. It, by default, also introduces such a handler for comments, however, there is a way to enable comments nontheless. This is because util.xml is used to parse human-facing data, where comments are generally a desirable feature, and also because comments are generally harmless.

     1

module:set_global();

     2

     3

local tostring = tostring;

     4

local filters = require "util.filters";

     5

     6

local function log_send(t, session)

     7

	if t and t ~= "" and t ~= " " then

     8

		session.log("debug", "SEND: %s", tostring(t));

     9

	end

    10

	return t;

    11

end

    12

    13

local function log_recv(t, session)

    14

	if t and t ~= "" and t ~= " " then

    15

		session.log("debug", "RECV: %s", tostring(t));

    16

	end

    17

	return t;

    18

end

    19

    20

local function init_raw_logging(session)

    21

	filters.add_filter(session, "stanzas/in",  log_recv, -10000);

    22

	filters.add_filter(session, "stanzas/out", log_send,  10000);

    23

end

    24

    25

filters.add_filter_hook(init_raw_logging);

    26

    27

function module.unload()

    28

	filters.remove_filter_hook(init_raw_logging);

    29

end