util.xml: Do not allow doctypes, comments or processing instructions Yes. This is as bad as it sounds. CVE pending. In Prosody itself, this only affects mod_websocket, which uses util.xml to parse the <open/> frame, thus allowing unauthenticated remote DoS using Billion Laughs. However, third-party modules using util.xml may also be affected by this. This commit installs handlers which disallow the use of doctype declarations and processing instructions without any escape hatch. It, by default, also introduces such a handler for comments, however, there is a way to enable comments nontheless. This is because util.xml is used to parse human-facing data, where comments are generally a desirable feature, and also because comments are generally harmless.

     1

     2

This file documents the structure of the roster object.

     3

     4

table roster {

     5

  [string bare_jid] = roster_item

     6

}

     7

     8

table roster_item {

     9

  string subscription = "none" | "to" | "from" | "both"

    10

  string name = Opaque string set by client. (optional)

    11

  set groups = a set of opaque strings set by the client

    12

  boolean ask = nil | "subscribe" - a value of true indicates subscription is pending

    13

}

    14

    15

The roster is available as

    16

 hosts[host].sessions[username].roster

    17

and a copy is made to session.roster for all sessions.

    18

    19

All modifications to a roster should be done through the rostermanager.