Mercurial Mercurial > prosody > prosody / annotate
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
.semgrep.yml
author Matthew Wild <mwild1@gmail.com>
Mon, 20 Feb 2023 18:10:15 +0000
branch0.12
changeset 12898 0598d822614f
parent 11293 c6965f3c321c
child 12721 898e99f49d80
permissions -rw-r--r--
mod_websocket: Fire pre-session-close event (fixes #1800) This event was added in a7c183bb4e64 and is required to make mod_smacks know that a session was intentionally closed and shouldn't be hibernated (see fcea4d9e7502). Because this was missing from mod_websocket's session.close(), mod_smacks would always attempt to hibernate websocket sessions even if they closed cleanly. That mod_websocket has its own copy of session.close() is something to fix another day (probably not in the stable branch). So for now this commit makes the minimal change to get things working again. Thanks to Damian and the Jitsi team for reporting.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
11293
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     1
 
rules:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     2
 
- id: log-variable-fmtstring
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     3
 
  patterns:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     4
 
    - pattern: log("...", $A)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     5
 
    - pattern-not: log("...", "...")
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     6
 
  message: Variable passed as format string to logging
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     7
 
  languages: [lua]
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     8
 
  severity: ERROR
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
     9
 
- id: module-log-variable-fmtstring
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    10
 
  patterns:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    11
 
    - pattern: module:log("...", $A)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    12
 
    - pattern-not: module:log("...", "...")
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    13
 
  message: Variable passed as format string to logging
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    14
 
  languages: [lua]
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    15
 
  severity: ERROR
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    16
 
- id: module-getopt-string-default
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    17
 
  patterns:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    18
 
    - pattern: module:get_option_string("...", $A)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    19
 
    - pattern-not: module:get_option_string("...", "...")
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    20
 
    - pattern-not: module:get_option_string("...", host)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    21
 
    - pattern-not: module:get_option_string("...", module.host)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    22
 
  message: Non-string default from :get_option_string
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    23
 
  severity: ERROR
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset 
    24
 
  languages: [lua]
prosody